LibWeb: Set width/height of ImageBitmap when deserializing or receiving

Lubrsi · gmta · commit 498e59f71dd4 · 2025-10-28T10:05:56.000-07:00
diff --git a/Libraries/LibWeb/HTML/ImageBitmap.cpp b/Libraries/LibWeb/HTML/ImageBitmap.cpp
@@ -84,7 +84,7 @@ WebIDL::ExceptionOr<void> ImageBitmap::serialization_steps(HTML::TransferDataEnc
 WebIDL::ExceptionOr<void> ImageBitmap::deserialization_steps(HTML::TransferDataDecoder& serialized, HTML::DeserializationMemory&)
 {
     // 1. Set value's bitmap data to serialized.[[BitmapData]].
-    m_bitmap = TRY(deserialize_bitmap(this->realm(), serialized));
+    set_bitmap(TRY(deserialize_bitmap(this->realm(), serialized)));
 
     return {};
 }
@@ -107,7 +107,7 @@ WebIDL::ExceptionOr<void> ImageBitmap::transfer_steps(HTML::TransferDataEncoder&
 WebIDL::ExceptionOr<void> ImageBitmap::transfer_receiving_steps(HTML::TransferDataDecoder& data_holder)
 {
     // 1. Set value's bitmap data to dataHolder.[[BitmapData]].
-    m_bitmap = TRY(deserialize_bitmap(this->realm(), data_holder));
+    set_bitmap(TRY(deserialize_bitmap(this->realm(), data_holder)));
 
     return {};
 }
diff --git a/Tests/LibWeb/Text/expected/HTML/ImageBitmap-retains-dimensions-when-serialized-or-transferred.txt b/Tests/LibWeb/Text/expected/HTML/ImageBitmap-retains-dimensions-when-serialized-or-transferred.txt
@@ -0,0 +1,15 @@
+before cloning:
+original imageBitmap width: 120
+original imageBitmap height: 120
+after cloning, before transferring:
+original imageBitmap width: 120
+original imageBitmap height: 120
+cloned imageBitmap width: 120
+cloned imageBitmap height: 120
+after cloning, after transferring:
+original imageBitmap width: 0
+original imageBitmap height: 0
+cloned imageBitmap width: 120
+cloned imageBitmap height: 120
+transferred imageBitmap width: 120
+transferred imageBitmap height: 120
diff --git a/Tests/LibWeb/Text/input/HTML/ImageBitmap-retains-dimensions-when-serialized-or-transferred.html b/Tests/LibWeb/Text/input/HTML/ImageBitmap-retains-dimensions-when-serialized-or-transferred.html
@@ -0,0 +1,33 @@
+<!DOCTYPE html>
+<script src="../include.js"></script>
+<script>
+    asyncTest((done) => {
+        const image = document.createElement("img");
+
+        image.onload = async () => {
+            const printDimensions = (name, imageBitmapToPrint) => {
+                println(`${name} imageBitmap width: ${imageBitmapToPrint.width}`);
+                println(`${name} imageBitmap height: ${imageBitmapToPrint.height}`);
+            };
+
+            const imageBitmap = await createImageBitmap(image);
+            println("before cloning:");
+            printDimensions("original", imageBitmap);
+
+            println("after cloning, before transferring:");
+            const clonedImageBitmap = structuredClone(imageBitmap);
+            printDimensions("original", imageBitmap);
+            printDimensions("cloned", clonedImageBitmap);
+
+            println("after cloning, after transferring:");
+            const transferredImageBitmap = structuredClone(imageBitmap, { transfer: [imageBitmap] });
+            printDimensions("original", imageBitmap);
+            printDimensions("cloned", clonedImageBitmap);
+            printDimensions("transferred", transferredImageBitmap);
+
+            done();
+        };
+
+        image.src = "../../../Assets/120.png";
+    });
+</script>

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ WebIDL::ExceptionOr<void> ImageBitmap::serialization_steps(HTML::TransferDataEnc`
`84`	`84`	`WebIDL::ExceptionOr<void> ImageBitmap::deserialization_steps(HTML::TransferDataDecoder& serialized, HTML::DeserializationMemory&)`
`85`	`85`	`{`
`86`	`86`	`// 1. Set value's bitmap data to serialized.[[BitmapData]].`
`87`		`- m_bitmap = TRY(deserialize_bitmap(this->realm(), serialized));`
	`87`	`+ set_bitmap(TRY(deserialize_bitmap(this->realm(), serialized)));`
`88`	`88`
`89`	`89`	`return {};`
`90`	`90`	`}`
`@@ -107,7 +107,7 @@ WebIDL::ExceptionOr<void> ImageBitmap::transfer_steps(HTML::TransferDataEncoder&`
`107`	`107`	`WebIDL::ExceptionOr<void> ImageBitmap::transfer_receiving_steps(HTML::TransferDataDecoder& data_holder)`
`108`	`108`	`{`
`109`	`109`	`// 1. Set value's bitmap data to dataHolder.[[BitmapData]].`
`110`		`- m_bitmap = TRY(deserialize_bitmap(this->realm(), data_holder));`
	`110`	`+ set_bitmap(TRY(deserialize_bitmap(this->realm(), data_holder)));`
`111`	`111`
`112`	`112`	`return {};`
`113`	`113`	`}`