Everywhere: Validate // NOTE: ... and // NB: ... comments

gmta · trflynn89 · commit 871f121c7547 · 2025-11-18T09:07:37.000-05:00
diff --git a/Libraries/LibWeb/Crypto/CryptoAlgorithms.h b/Libraries/LibWeb/Crypto/CryptoAlgorithms.h
@@ -146,7 +146,7 @@ struct RsaKeyGenParams : public AlgorithmParams {
     }
 
     u32 modulus_length;
-    // NOTE that the raw data is going to be in Big Endian u8[] format
+    // NOTE: The raw data is going to be in Big Endian u8[] format
     ::Crypto::UnsignedBigInteger public_exponent;
 
     static JS::ThrowCompletionOr<NonnullOwnPtr<AlgorithmParams>> from_value(JS::VM&, JS::Value);
diff --git a/Meta/check-style.py b/Meta/check-style.py
@@ -58,7 +58,7 @@
 SINGLE_PAGE_HTML_SPEC_LINK = re.compile("//.*https://html\\.spec\\.whatwg\\.org/#")
 
 # We similarily check and disallow AD-HOCs and FIXMEs that aren't followed by a colon.
-INVALID_AD_HOC_OR_FIXME = re.compile(r'^(?:[\s\d./\-(*]+(?:AD-HOC|FIXME)[^:]|.*"FIXME[^:"]).*$', re.MULTILINE)
+INVALID_AD_HOC_OR_FIXME = re.compile(r'^(?:[\s\d./\-(*]+(?:AD-HOC|FIXME|NB|NOTE)[^:]|.*"FIXME[^:"]).*$', re.MULTILINE)
 
 
 def should_check_file(filename):

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,7 @@ struct RsaKeyGenParams : public AlgorithmParams {`
`146`	`146`	`}`
`147`	`147`
`148`	`148`	`u32 modulus_length;`
`149`		`- // NOTE that the raw data is going to be in Big Endian u8[] format`
	`149`	`+ // NOTE: The raw data is going to be in Big Endian u8[] format`
`150`	`150`	`::Crypto::UnsignedBigInteger public_exponent;`
`151`	`151`
`152`	`152`	`static JS::ThrowCompletionOr<NonnullOwnPtr<AlgorithmParams>> from_value(JS::VM&, JS::Value);`