Skip to content

Commit c75f134

Browse files
Zaggy1024gmta
authored andcommitted
LibWeb: Disconnect all sinks when forgetting HTMLMediaElement tracks
This prevents a crash when playing videos on Newgrounds.
1 parent 9f44fcb commit c75f134

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

Libraries/LibWeb/HTML/AudioTrackList.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@ void AudioTrackList::add_track(Badge<HTMLMediaElement>, GC::Ref<AudioTrack> audi
5252

5353
void AudioTrackList::remove_all_tracks(Badge<HTMLMediaElement>)
5454
{
55+
for (auto& audio_track : m_audio_tracks)
56+
audio_track->set_enabled(false);
5557
m_audio_tracks.clear();
5658
}
5759

Libraries/LibWeb/HTML/VideoTrackList.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@ void VideoTrackList::add_track(Badge<HTMLMediaElement>, GC::Ref<VideoTrack> vide
5252

5353
void VideoTrackList::remove_all_tracks(Badge<HTMLMediaElement>)
5454
{
55+
for (auto& video_track : m_video_tracks)
56+
video_track->set_selected(false);
5557
m_video_tracks.clear();
5658
}
5759

0 commit comments

Comments
 (0)