Skip to content

Commit ce2c4a3

Browse files
InvalidUsernameExceptiontrflynn89
authored andcommitted
LibGfx+LibWeb: Fix compile errors in clang-cl from recent header cleanup
The recent commits 28ba610 and 70c4ed2 adjusted some include directives to avoid excessive recompilation when changing some header files. This has broken compilation with clang-cl on Windows without getting noticed before the PRs were merged.
1 parent 0eceee0 commit ce2c4a3

File tree

5 files changed

+8
-2
lines changed

5 files changed

+8
-2
lines changed

Libraries/LibGfx/Painter.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
* SPDX-License-Identifier: BSD-2-Clause
55
*/
66

7+
#include <LibGfx/Bitmap.h>
78
#include <LibGfx/Painter.h>
89
#include <LibGfx/PainterSkia.h>
910
#include <LibGfx/PaintingSurface.h>

Libraries/LibWeb/CSS/CSSImportRule.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ CSSImportRule::CSSImportRule(JS::Realm& realm, URL url, GC::Ptr<DOM::Document> d
4040
{
4141
}
4242

43+
CSSImportRule::~CSSImportRule() = default;
44+
4345
void CSSImportRule::initialize(JS::Realm& realm)
4446
{
4547
WEB_SET_PROTOTYPE_FOR_INTERFACE(CSSImportRule);

Libraries/LibWeb/CSS/CSSImportRule.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
#include <LibWeb/CSS/URL.h>
1414
#include <LibWeb/DOM/DocumentLoadEventDelayer.h>
1515
#include <LibWeb/Export.h>
16+
#include <LibWeb/Forward.h>
1617

1718
namespace Web::CSS {
1819

@@ -24,7 +25,7 @@ class WEB_API CSSImportRule final
2425
public:
2526
[[nodiscard]] static GC::Ref<CSSImportRule> create(JS::Realm&, URL, GC::Ptr<DOM::Document>, RefPtr<Supports>, Vector<NonnullRefPtr<MediaQuery>>);
2627

27-
virtual ~CSSImportRule() = default;
28+
virtual ~CSSImportRule();
2829

2930
URL const& url() const { return m_url; }
3031
String href() const { return m_url.url(); }

Libraries/LibWeb/HTML/ImageBitmap.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@ ImageBitmap::ImageBitmap(JS::Realm& realm)
5858
{
5959
}
6060

61+
ImageBitmap::~ImageBitmap() = default;
62+
6163
void ImageBitmap::initialize(JS::Realm& realm)
6264
{
6365
WEB_SET_PROTOTYPE_FOR_INTERFACE(ImageBitmap);

Libraries/LibWeb/HTML/ImageBitmap.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ class ImageBitmap final : public Bindings::PlatformObject
3535

3636
public:
3737
static GC::Ref<ImageBitmap> create(JS::Realm&);
38-
virtual ~ImageBitmap() override = default;
38+
virtual ~ImageBitmap() override;
3939

4040
// ^Web::Bindings::Serializable
4141
virtual HTML::SerializeType serialize_type() const override { return HTML::SerializeType::ImageBitmap; }

0 commit comments

Comments
 (0)