LibJS: Do not verify cycle root's status is linked in CyclicModule

caztanj · gmta · commit e93f44112d86 · 2025-10-22T11:54:56.000+02:00
This VERIFY is both incorrect and redundant. The VERIFY at step 2
verifies the status when evaluate is called on m_cycle_root.
diff --git a/Libraries/LibJS/CyclicModule.cpp b/Libraries/LibJS/CyclicModule.cpp
@@ -344,7 +344,6 @@ ThrowCompletionOr<GC::Ref<Promise>> CyclicModule::evaluate(VM& vm)
     if ((m_status == ModuleStatus::EvaluatingAsync || m_status == ModuleStatus::Evaluated) && m_cycle_root != this) {
         // Note: This will continue this function with module.[[CycleRoot]]
         VERIFY(m_cycle_root);
-        VERIFY(m_cycle_root->m_status == ModuleStatus::Linked);
         dbgln_if(JS_MODULE_DEBUG, "[JS MODULE] evaluate[{}](vm) deferring to cycle root at {}", this, m_cycle_root.ptr());
         return m_cycle_root->evaluate(vm);
     }
diff --git a/Tests/LibWeb/Crash/JS/cyclic-async-module-a.mjs b/Tests/LibWeb/Crash/JS/cyclic-async-module-a.mjs
@@ -0,0 +1,3 @@
+import { foo } from "./cyclic-async-module-b.mjs";
+
+await new Promise(resolve => setTimeout(resolve, 200));
diff --git a/Tests/LibWeb/Crash/JS/cyclic-async-module-b.mjs b/Tests/LibWeb/Crash/JS/cyclic-async-module-b.mjs
@@ -0,0 +1,3 @@
+import "./cyclic-async-module-a.mjs";
+
+export const foo = "value from B";
diff --git a/Tests/LibWeb/Crash/JS/cyclic-async-module.html b/Tests/LibWeb/Crash/JS/cyclic-async-module.html
@@ -0,0 +1,2 @@
+<!DOCTYPE html>
+<script src="./cyclic-async-module.mjs"></script>
diff --git a/Tests/LibWeb/Crash/JS/cyclic-async-module.mjs b/Tests/LibWeb/Crash/JS/cyclic-async-module.mjs
@@ -0,0 +1,7 @@
+(async function () {
+    const first = import("./cyclic-async-module-a.mjs");
+    const second = import("./cyclic-async-module-b.mjs");
+
+    await first;
+    await second;
+})();

Original file line number	Diff line number	Diff line change
`@@ -344,7 +344,6 @@ ThrowCompletionOr<GC::Ref<Promise>> CyclicModule::evaluate(VM& vm)`
`344`	`344`	`if ((m_status == ModuleStatus::EvaluatingAsync \|\| m_status == ModuleStatus::Evaluated) && m_cycle_root != this) {`
`345`	`345`	`// Note: This will continue this function with module.[[CycleRoot]]`
`346`	`346`	`VERIFY(m_cycle_root);`
`347`		`- VERIFY(m_cycle_root->m_status == ModuleStatus::Linked);`
`348`	`347`	`dbgln_if(JS_MODULE_DEBUG, "[JS MODULE] evaluate[{}](vm) deferring to cycle root at {}", this, m_cycle_root.ptr());`
`349`	`348`	`return m_cycle_root->evaluate(vm);`
`350`	`349`	`}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+import { foo } from "./cyclic-async-module-b.mjs";`
	`2`	`+`
	`3`	`+await new Promise(resolve => setTimeout(resolve, 200));`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+import "./cyclic-async-module-a.mjs";`
	`2`	`+`
	`3`	`+export const foo = "value from B";`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+<!DOCTYPE html>`
	`2`	`+<script src="./cyclic-async-module.mjs"></script>`