Skip to content

Order Arrow CSR metadata test#521

Merged
adsharma merged 2 commits into
mainfrom
codex/order-arrow-csr-test
May 25, 2026
Merged

Order Arrow CSR metadata test#521
adsharma merged 2 commits into
mainfrom
codex/order-arrow-csr-test

Conversation

@adsharma
Copy link
Copy Markdown
Contributor

Summary

Add an explicit ORDER BY to the four-thread Arrow CSR metadata test so the query contract matches the ordered CSR shape expected by the metadata collector.

Root cause

The test relied on the natural output order of a MATCH without ORDER BY. Windows can produce the same rows in a different valid order, which causes the CSR metadata collector to reject the stream when source row IDs go backwards.

Validation

  • cmake --build build/release --target api_test
  • build/release/test/api/api_test --gtest_filter=ArrowTest.queryAsArrowDirectCSRRowIDProjectionKeepsCSRMetadataWithFourThreads
  • MAX_NUM_THREADS=4 build/release/test/api/api_test --gtest_filter=ArrowTest.queryAsArrowDirectCSRRowIDProjectionKeepsCSRMetadataWithFourThreads

@adsharma adsharma changed the title [codex] Order Arrow CSR metadata test Order Arrow CSR metadata test May 25, 2026
@adsharma adsharma marked this pull request as ready for review May 25, 2026 21:00
@adsharma adsharma merged commit 12a9c52 into main May 25, 2026
8 checks passed
@adsharma adsharma deleted the codex/order-arrow-csr-test branch May 25, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant