Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Delete profile page #33

Merged
merged 6 commits into from Sep 21, 2020
Merged

Fix: Delete profile page #33

merged 6 commits into from Sep 21, 2020

Conversation

chelsabeth
Copy link
Contributor

@chelsabeth chelsabeth commented Sep 16, 2020

Hello Team 馃憢 It's me again 馃槃

This PR covers these Trello cards 猬囷笍
https://trello.com/c/yzdSFv9r
https://trello.com/c/lfRmHfXo

  • We decided as a team to take out the profile page because it was redundant and not needed 馃憤
  • I decided to change the routing names in the mobile hamburger menu to be more accurate descriptions of the pages
  • I also added a modal and form to begin creating a new savings contribution in the savings goal

It looks like I have 2 merge conflicts, but I am lowkey afraid to mess with them. If we could look over them as a team I would greatly appreciate that 馃

@chelsabeth chelsabeth marked this pull request as ready for review September 16, 2020 18:04
Copy link
Contributor

@vtopham vtopham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Clean code and nice changes.

@chelsabeth chelsabeth merged commit ab35461 into main Sep 21, 2020
@chelsabeth chelsabeth deleted the fix/deleteprofilepage/chelsea branch September 21, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants