Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More scrubbers #35

Merged
merged 7 commits into from Dec 4, 2019
Merged

More scrubbers #35

merged 7 commits into from Dec 4, 2019

Conversation

@WebWallen
Copy link
Contributor

WebWallen commented Dec 3, 2019

Not entirely sure how to test these TBH, but in theory the other scrubbers are done (at least all of them I could find a migration table for). The correct error message always shows but I'm not seeing how the data is actually posted (in the case of Question Groups, it doesn't look like there's a function to add anything in the Model... perhaps that's true elsewhere?).

New Scrubbers (user_missions, default_missions, users, profile, and question_groups)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Change Status

  • Complete, tested, ready to review and merge
  • [ X ] Complete, but not tested (may need new tests)
  • Incomplete/work-in-progress, PR is for discussion/feedback

Checklist

  • [X ] My code follows the style guidelines of this project
  • [X ] I have performed a self-review of my own code
  • My code has been reviewed by at least one peer
  • [X ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • There are no merge conflicts
@WebWallen WebWallen requested review from Roman-Jordan and DaytonS3 Dec 3, 2019
Copy link
Contributor

Roman-Jordan left a comment

I agree with the increased need for testing, code looks good

@DaytonS3 DaytonS3 merged commit 212e28b into master Dec 4, 2019
4 checks passed
4 checks passed
build (8.x)
Details
build (10.x)
Details
build (13.x)
Details
Travis CI - Pull Request Build Passed
Details
@Roman-Jordan Roman-Jordan deleted the more-scrubbers branch Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.