Michael Brady: Sprint 3 #33
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clearly something you have a lot more experience in than me, and I liked your article! Definitely can't wait to see more, is there any way we can get a LinkedIn button next to your github? Just something to signal 'Professional looking for candidates to work for'
Great reminder, had forgotten to uncomment the linkedin logo. It's live now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your visualizations look pretty nice, great job and effort! One thing to note with things like Year is that altair infers a lot of stuff, which makes it super easy to use broadly but also somewhat of a pain in the ass to get specific, and that comma in the years is an example of that. One workaround is to create a new column or overwrite the Year column as a string, as this will pass in and not incur the wrath of the janky Altair inference. In general transferring to strings with these high level charting libraries is a good idea anyway since you can coerce.
Keep up the good work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under 'Assignment' you have the worksheet blank so Im not sure if youve done homework, if any of the above work was for the assignment let me know plz! ty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, decent replications, i look forward to seeing your data storytelling project! Good work this week
I expect to refine both the website (particularly the copy) and my data storytelling ideas as the week progresses.