From b1137f36e83f8fbc934a974f143695047c5e7992 Mon Sep 17 00:00:00 2001 From: parthkirsan Date: Tue, 23 Sep 2025 14:04:34 +0530 Subject: [PATCH] add useremotediscovery in cli config --- src/lib/ctx.ts | 5 +++++ src/lib/schemaValidation.ts | 4 ++++ src/lib/snapshotQueue.ts | 2 +- src/tasks/createBuildExec.ts | 2 +- src/types.ts | 1 + 5 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/lib/ctx.ts b/src/lib/ctx.ts index dcd43c1..fc9ea78 100644 --- a/src/lib/ctx.ts +++ b/src/lib/ctx.ts @@ -25,6 +25,7 @@ export default (options: Record): Context => { let buildNameObj: string; let allowDuplicateSnapshotNames: boolean = false; let useLambdaInternal: boolean = false; + let useRemoteDiscovery: boolean = false; let useExtendedViewport: boolean = false; let loadDomContent: boolean = false; try { @@ -108,6 +109,9 @@ export default (options: Record): Context => { if (config.useLambdaInternal) { useLambdaInternal = true; } + if (config.useRemoteDiscovery) { + useRemoteDiscovery = true; + } if (config.useExtendedViewport) { useExtendedViewport = true; } @@ -146,6 +150,7 @@ export default (options: Record): Context => { requestHeaders: config.requestHeaders || {}, allowDuplicateSnapshotNames: allowDuplicateSnapshotNames, useLambdaInternal: useLambdaInternal, + useRemoteDiscovery: useRemoteDiscovery, useExtendedViewport: useExtendedViewport, loadDomContent: loadDomContent, approvalThreshold: config.approvalThreshold, diff --git a/src/lib/schemaValidation.ts b/src/lib/schemaValidation.ts index 10c7973..518a404 100644 --- a/src/lib/schemaValidation.ts +++ b/src/lib/schemaValidation.ts @@ -272,6 +272,10 @@ const ConfigSchema = { type: "boolean", errorMessage: "Invalid config; useLambdaInternal must be true/false" }, + useRemoteDiscovery: { + type: "boolean", + errorMessage: "Invalid config; useRemoteDiscovery must be true/false" + }, useExtendedViewport: { type: "boolean", errorMessage: "Invalid config; useExtendedViewport must be true/false" diff --git a/src/lib/snapshotQueue.ts b/src/lib/snapshotQueue.ts index be66ae9..b50ce55 100644 --- a/src/lib/snapshotQueue.ts +++ b/src/lib/snapshotQueue.ts @@ -327,7 +327,7 @@ export default class Queue { } let processedSnapshot, warnings, discoveryErrors; - if (this.ctx.env.USE_REMOTE_DISCOVERY) { + if (this.ctx.env.USE_REMOTE_DISCOVERY || this.ctx.config.useRemoteDiscovery) { this.ctx.log.debug(`Using remote discovery`); let result = await prepareSnapshot(snapshot, this.ctx); diff --git a/src/tasks/createBuildExec.ts b/src/tasks/createBuildExec.ts index 9a469af..ead669c 100644 --- a/src/tasks/createBuildExec.ts +++ b/src/tasks/createBuildExec.ts @@ -36,7 +36,7 @@ export default (ctx: Context): ListrTask>; allowDuplicateSnapshotNames?: boolean; useLambdaInternal?: boolean; + useRemoteDiscovery?: boolean; useExtendedViewport?: boolean; loadDomContent?: boolean; approvalThreshold?: number;