From 675415d123172658305193240e41b8ebca6aced7 Mon Sep 17 00:00:00 2001 From: WinterSolstice8 <60417494+wintersolstice8@users.noreply.github.com> Date: Tue, 7 May 2024 20:06:21 -0600 Subject: [PATCH] [dbtool] Fix potential error in migration The missing db.commit() may cause the sql to not run. --- tools/migrations/039_refactor_char_settings.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/migrations/039_refactor_char_settings.py b/tools/migrations/039_refactor_char_settings.py index 5c42d4b10f7..e19c7857855 100644 --- a/tools/migrations/039_refactor_char_settings.py +++ b/tools/migrations/039_refactor_char_settings.py @@ -59,6 +59,7 @@ def migrate(cur, db): # Add default row for each character into new char_flags table, on duplicate do nothing. cur.execute("INSERT INTO char_flags (charid) SELECT charid FROM chars ON DUPLICATE KEY UPDATE char_flags.disconnecting = char_flags.disconnecting;"); + db.commit() except mariadb.Error as err: print("Something went wrong: {}".format(err))