From 1dea359836c7c01427144bad22afaf2b41a8675a Mon Sep 17 00:00:00 2001 From: Corey Sotiropoulos Date: Tue, 20 Jan 2026 03:50:27 +0000 Subject: [PATCH 1/2] [ci] Don't fail workflow on log errors Startup checks script already fails if there are errors, then will retry. If a retry succeeds, we don't want to fail the workflow due to logs from the failed attempt. Still report them in the summary for information purposes. --- .github/workflows/docker_test.yml | 14 +++++--------- .github/workflows/runner_test.yml | 14 +++++--------- 2 files changed, 10 insertions(+), 18 deletions(-) diff --git a/.github/workflows/docker_test.yml b/.github/workflows/docker_test.yml index 287770e672b..5ee11002b20 100644 --- a/.github/workflows/docker_test.yml +++ b/.github/workflows/docker_test.yml @@ -152,7 +152,7 @@ jobs: if grep -qi "warning\|error\|crash\|critical" "$log_file"; then found_issues=true log_name=$(basename "$log_file" .log | sed 's/.*/\u&/; s/-\(.\)/ \u\1/g') - echo "### :x: ${log_name} Checks Failed" >> $GITHUB_STEP_SUMMARY + echo "### :warning: ${log_name} Checks" >> $GITHUB_STEP_SUMMARY echo "\`\`\`" >> $GITHUB_STEP_SUMMARY grep -i "warning\|error\|crash\|critical" "$log_file" >> $GITHUB_STEP_SUMMARY echo "\`\`\`" >> $GITHUB_STEP_SUMMARY @@ -160,12 +160,9 @@ jobs: fi fi done - if [[ "$found_issues" == "false" ]]; then - if [[ "${{ steps.startup_checks.outcome }}" != "success" ]]; then - echo "### :x: Startup checks failed, but no specific errors were found." >> $GITHUB_STEP_SUMMARY - echo "Check the logs for details." >> $GITHUB_STEP_SUMMARY - found_issues=true - fi + if [[ "$found_issues" == "false" && "${{ steps.startup_checks.outcome }}" != "success" ]]; then + echo "### :x: Startup checks failed, but no specific errors were found." >> $GITHUB_STEP_SUMMARY + echo "Check the logs for details." >> $GITHUB_STEP_SUMMARY fi echo "

View Logs

" >> $GITHUB_STEP_SUMMARY echo "" >> $GITHUB_STEP_SUMMARY @@ -179,7 +176,6 @@ jobs: fi done echo "
" >> $GITHUB_STEP_SUMMARY - echo "issues_found=$found_issues" >> $GITHUB_OUTPUT - name: Stop container run: | @@ -187,7 +183,7 @@ jobs: docker rm test-server - name: Fail Workflow if Checks Failed - if: ${{ steps.xi_test.outcome == 'failure' || steps.startup_checks.outcome == 'failure' || steps.summarize_checks.outputs.issues_found == 'true' }} + if: ${{ steps.xi_test.outcome == 'failure' || steps.startup_checks.outcome == 'failure' }} run: | echo "Startup checks failed. See summary for details." exit 1 diff --git a/.github/workflows/runner_test.yml b/.github/workflows/runner_test.yml index 348d52e3020..1285759e377 100644 --- a/.github/workflows/runner_test.yml +++ b/.github/workflows/runner_test.yml @@ -202,7 +202,7 @@ jobs: if grep -qi "warning\|error\|crash\|critical" "$log_file"; then found_issues=true log_name=$(basename "$log_file" .log | sed 's/.*/\u&/; s/-\(.\)/ \u\1/g') - echo "### :x: ${log_name} Checks Failed" >> $GITHUB_STEP_SUMMARY + echo "### :warning: ${log_name} Checks" >> $GITHUB_STEP_SUMMARY echo "\`\`\`" >> $GITHUB_STEP_SUMMARY grep -i "warning\|error\|crash\|critical" "$log_file" >> $GITHUB_STEP_SUMMARY echo "\`\`\`" >> $GITHUB_STEP_SUMMARY @@ -210,12 +210,9 @@ jobs: fi fi done - if [[ "$found_issues" == "false" ]]; then - if [[ "${{ steps.startup_checks.outcome }}" != "success" ]]; then - echo "### :x: Startup checks failed, but no specific errors were found." >> $GITHUB_STEP_SUMMARY - echo "Check the logs for details." >> $GITHUB_STEP_SUMMARY - found_issues=true - fi + if [[ "$found_issues" == "false" && "${{ steps.startup_checks.outcome }}" != "success" ]]; then + echo "### :x: Startup checks failed, but no specific errors were found." >> $GITHUB_STEP_SUMMARY + echo "Check the logs for details." >> $GITHUB_STEP_SUMMARY fi echo "

View Logs

" >> $GITHUB_STEP_SUMMARY echo "" >> $GITHUB_STEP_SUMMARY @@ -229,10 +226,9 @@ jobs: fi done echo "
" >> $GITHUB_STEP_SUMMARY - echo "issues_found=$found_issues" >> $GITHUB_OUTPUT - name: Fail Workflow if Checks Failed - if: ${{ steps.xi_test.outcome == 'failure' || steps.startup_checks.outcome == 'failure' || steps.summarize_checks.outputs.issues_found == 'true' }} + if: ${{ steps.xi_test.outcome == 'failure' || steps.startup_checks.outcome == 'failure' }} run: | echo "Startup checks failed. See summary for details." exit 1 From 97ea90f40086f3969355d5467d9e76b1fa3120bf Mon Sep 17 00:00:00 2001 From: Corey Sotiropoulos Date: Tue, 20 Jan 2026 04:04:57 +0000 Subject: [PATCH 2/2] [ci] Don't create xi_test status check on PRs I think this is what's causing the "Resource not accessible by integration" warning. --- .github/workflows/docker_test.yml | 2 +- .github/workflows/runner_test.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/docker_test.yml b/.github/workflows/docker_test.yml index 5ee11002b20..8600f0f9e51 100644 --- a/.github/workflows/docker_test.yml +++ b/.github/workflows/docker_test.yml @@ -130,7 +130,7 @@ jobs: github-report: true summary: true pull-request: false - status-check: true + status-check: ${{ github.event_name != 'pull_request' }} status-check-name: "xi_test (${{ format('docker-{0}', inputs.os) }})" annotate: true upload-artifact: true diff --git a/.github/workflows/runner_test.yml b/.github/workflows/runner_test.yml index 1285759e377..1a2e0fc4a57 100644 --- a/.github/workflows/runner_test.yml +++ b/.github/workflows/runner_test.yml @@ -176,7 +176,7 @@ jobs: github-report: true summary: true pull-request: false - status-check: true + status-check: ${{ github.event_name != 'pull_request' }} status-check-name: 'xi_test (${{ inputs.runner }})' annotate: true upload-artifact: true