From 038cc3131426605573844610d1a9a26f416dc9da Mon Sep 17 00:00:00 2001 From: sruon Date: Mon, 2 Feb 2026 18:28:57 -0700 Subject: [PATCH] Familiar does not boost stats other than HP --- scripts/actions/abilities/pets/rage.lua | 4 +++- scripts/effects/berserk.lua | 2 +- scripts/globals/pets.lua | 9 --------- 3 files changed, 4 insertions(+), 11 deletions(-) diff --git a/scripts/actions/abilities/pets/rage.lua b/scripts/actions/abilities/pets/rage.lua index 860c9901c72..1f4376d7ad2 100644 --- a/scripts/actions/abilities/pets/rage.lua +++ b/scripts/actions/abilities/pets/rage.lua @@ -1,6 +1,6 @@ ----------------------------------- -- Generic jug pet skill --- TODO: verify functionality with regards to jug pet differences from regular mobs +-- 50% ATTP, -50% DEFP for 4 (0 TP) to 9 (3000 TP) minutes ----------------------------------- ---@type TAbilityPet local abilityObject = {} @@ -11,6 +11,8 @@ abilityObject.onAbilityCheck = function(player, target, ability) end abilityObject.onPetAbility = function(target, pet, petskill, owner, action) + -- TODO: Either the mobskill below is wrong or the Ready move is customized. + -- Should grant a stackable BERSERK effect of 50%/-50% for 4 to 9 minutes depending on TP. local result = xi.actions.mobskills[skillName].onMobWeaponSkill(target, pet, petskill) return result diff --git a/scripts/effects/berserk.lua b/scripts/effects/berserk.lua index a2f5211f8df..cb72b011cfb 100644 --- a/scripts/effects/berserk.lua +++ b/scripts/effects/berserk.lua @@ -13,7 +13,7 @@ effectObject.onEffectGain = function(target, effect) effect:addMod(xi.mod.ATTP, power) effect:addMod(xi.mod.RATTP, power) - effect:addMod(xi.mod.DEFP, -25) + effect:addMod(xi.mod.DEFP, -25) -- TODO: This is supposed to mirror power in most cases -- Job Point Bonuses effect:addMod(xi.mod.ATT, jpEffect) diff --git a/scripts/globals/pets.lua b/scripts/globals/pets.lua index 3cc82940c98..e4b3f9f8557 100644 --- a/scripts/globals/pets.lua +++ b/scripts/globals/pets.lua @@ -164,15 +164,6 @@ xi.pet.applyFamiliarBuffs = function(owner, pet) -- wakes up pets pet:addHP(addedHP) - -- adds % bonuses to the following stats - -- TODO are these the only stats boosted? - pet:addMod(xi.mod.ATTP, familiarBoost) - pet:addMod(xi.mod.RATTP, familiarBoost) - pet:addMod(xi.mod.DEFP, familiarBoost) - pet:addMod(xi.mod.ACC, pet:getMod(xi.mod.ACC) * familiarBoostPerc) - pet:addMod(xi.mod.RACC, pet:getMod(xi.mod.RACC) * familiarBoostPerc) - pet:addMod(xi.mod.EVA, pet:getMod(xi.mod.EVA) * familiarBoostPerc) - -- TODO does familiar give some bonus resistance to crowd control? Is it only for mob pets? -- Lots of reports of mobs using Familiar and the pet having higher chance to resist bind/sleep/etc end