Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #69 Cannot parse automatically the right configurations in PROPERTIES mode when we create a new connector #70

Merged
merged 2 commits into from Mar 16, 2018

Conversation

@asdf2014
Copy link
Contributor

commented Mar 13, 2018

Fix #69 Cannot parse automatically the right configurations in PROPERTIES mode when we create a new connector

image

image


This change is Reviewable

Fix #69 Cannot parse automatically the right configurations in PROPER…
…TIES mode when we create a new connector
@asdf2014

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2018

Changes in configuration-editor-properties.component.js are used to resolve the following issues...

image

@@ -1,12 +1,10 @@
<md-tabs md-dynamic-height>
<md-tab label="Properties">
<md-tab-body>

This comment has been minimized.

Copy link
@jglambed

jglambed Mar 13, 2018

Collaborator

why removing the <md-tab-body> here?

@jglambed

This comment has been minimized.

Copy link
Collaborator

commented Mar 13, 2018

@asdf2014 Good catch. We had missed that after the latest changes. I just got a question about removing the <md-tab-body> tag. Is this change really needed?

@asdf2014

This comment has been minimized.

Copy link
Contributor Author

commented Mar 16, 2018

@jglambed Indeed, it's not necessary. Already rolled it back.

@jglambed jglambed merged commit 06e5f2c into Landoop:master Mar 16, 2018

1 check was pending

code-review/reviewable 1 file left
Details

@asdf2014 asdf2014 deleted the asdf2014:properties_auto branch Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.