Skip to content

Conversation

@abettermap
Copy link
Contributor

@abettermap abettermap commented Mar 19, 2021

@abettermap
Copy link
Contributor Author

@rperlin-ela i got a late start today so decided to push on through like the good ol' days, so have a look at the 3 issues i included in this PR so far when you get a chance. there's some quirks with 2D/3D toggle on mobile, i had problems w/that before, so i'll give a fresh look tomorrow but may have to circle back to that another time. it's all definitely working but i just can't get it to center properly on mobile when toggling, and it's very apparent when a popup for selected community is present.

@rperlin-ela
Copy link
Collaborator

Quick look on desktop before shutting down for the night but all looking good, can commit or wait as you like in the morning.

@abettermap
Copy link
Contributor Author

Thanks, I'll keep plugging away on this branch. I'm trying to get in the habit/convention of

"WIP" in the PR title + not assigning you as Reviewer = not ready for primetime yet

If no WIP and you're Reviewer, it's ripe for the pickin.

@abettermap abettermap changed the title WIP: Sow3.sm new feats SOW3.1.4: smaller new feature additions Mar 19, 2021
@abettermap abettermap requested a review from rperlin-ela March 19, 2021 22:55
@abettermap
Copy link
Contributor Author

@rperlin-ela all set for review. still would like to punt these until Week 4 if they're of concern:

  1. 2D/3D (3D/2D: don't force, allow setting consistently #194): if popup is present when this button is toggled on mobile, zoom/pan centered properly in the map (it's offset in 3D right now but wasn't before when we just had the "reset pitch" btn)
  2. Improve cross-panel interactions #195 : if you're not seeing it, or if you are and don't feel it's a problem, case closed. or if you want to take the quick and dirty way out, that's simply adjusting text.

Copy link
Collaborator

@rperlin-ela rperlin-ela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my comment on #196, looks good to go!

@abettermap abettermap merged commit 4d86db2 into master Mar 20, 2021
@abettermap abettermap deleted the sow3.sm-new-feats branch March 20, 2021 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants