-
Notifications
You must be signed in to change notification settings - Fork 5
SOW3.1.4: smaller new feature additions #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@rperlin-ela i got a late start today so decided to push on through like the good ol' days, so have a look at the 3 issues i included in this PR so far when you get a chance. there's some quirks with 2D/3D toggle on mobile, i had problems w/that before, so i'll give a fresh look tomorrow but may have to circle back to that another time. it's all definitely working but i just can't get it to center properly on mobile when toggling, and it's very apparent when a popup for selected community is present. |
|
Quick look on desktop before shutting down for the night but all looking good, can commit or wait as you like in the morning. |
|
Thanks, I'll keep plugging away on this branch. I'm trying to get in the habit/convention of If no WIP and you're Reviewer, it's ripe for the pickin. |
|
@rperlin-ela all set for review. still would like to punt these until Week 4 if they're of concern:
|
rperlin-ela
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my comment on #196, looks good to go!
Issues resolved by this pull request