Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Norwegian: Completed! #1747

Merged
merged 5 commits into from May 15, 2021
Merged

Conversation

dsbilling
Copy link
Contributor

@dsbilling dsbilling commented May 11, 2021

Full comparison with English file, updated accordingly. Including countries!

Copy link
Member

@caouecs caouecs left a comment

Problem with validation-inline and :attribute

and don't set sort of tags

'previous' => '« Forrige',
'next' => 'Neste »',
Copy link
Member

@caouecs caouecs May 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why set the order ?

Copy link
Contributor Author

@dsbilling dsbilling May 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared to and changed according to the English file.

'numeric' => ':attribute må være mellom :min - :max.',
'file' => ':attribute må være mellom :min - :max kilobytes.',
'string' => ':attribute må være mellom :min - :max tegn.',
'array' => ':attribute må ha mellom :min - :max elementer.',
Copy link
Member

@caouecs caouecs May 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sort

Copy link
Contributor Author

@dsbilling dsbilling May 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, compared to and changed according to the English file.

locales/nb/validation-inline.php Outdated Show resolved Hide resolved
'string' => ':attribute må være mellom :min - :max tegn.',
'array' => ':attribute må ha mellom :min - :max elementer.',
Copy link
Member

@caouecs caouecs May 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sort

Copy link
Contributor Author

@dsbilling dsbilling May 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, compared to and changed according to the English file.

locales/nb/nb.json Show resolved Hide resolved
@dsbilling dsbilling requested a review from caouecs May 15, 2021
@caouecs caouecs merged commit e03c05a into Laravel-Lang:master May 15, 2021
1 check failed
@caouecs
Copy link
Member

caouecs commented May 15, 2021

Thank you, I will sort tags

@caouecs
Copy link
Member

caouecs commented May 15, 2021

For country names, if it's same, we can add its in exclude file

@dsbilling
Copy link
Contributor Author

dsbilling commented May 16, 2021

For country names, if it's same, we can add its in exclude file

Yes, I have checked everything.

@caouecs
Copy link
Member

caouecs commented May 16, 2021

Ok, I add these tags ( see: https://laravel-lang.github.io/lang/statuses/nb.html ) in exclude file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants