Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting projects #1748

Merged
merged 71 commits into from May 20, 2021
Merged

Conversation

andrey-helldar
Copy link
Member

@andrey-helldar andrey-helldar commented May 13, 2021

Note

The development is in progress. The structure of localization and script files can change during development.
Once it is over, everyone will be able to suggest their own adjustments.

#1702 (comment)

@andrey-helldar andrey-helldar changed the title Splitting projects [10.x] Splitting projects May 13, 2021
@andrey-helldar andrey-helldar changed the title [10.x] Splitting projects Splitting projects May 13, 2021
@luisprmat
Copy link
Member

luisprmat commented May 13, 2021

Hopefully the keys starting with Lang::get('...') are not forgotten.

For example these.

Some translations also begin with @lang(...)

@andrey-helldar
Copy link
Member Author

andrey-helldar commented May 14, 2021

@luisprmat, thank you!

@andrey-helldar
Copy link
Member Author

andrey-helldar commented May 14, 2021

@caouecs, my code is ready BUT:

  1. I will remove the Draft tag from this PR when Norwegian: Completed! #1747 is accepted. I did not add split localization files to this PR, because there is one open PR in the project.
  2. It will need to be merged only after accepting other PRs. This must be done because I will need to run php app/split-packages.php script file once, which will split the keys. Otherwise, other developers will be forced to manually fix conflicts.
  3. Fixed compilation error for status files. This one condition dropped the array.
  4. The Jetstream and Fortify projects do not have language files, but they use translations. I added these packages in dependencies and when the Foo script is executed, it collects all the keys from them, forming files.
  5. I split the files by packages:

image

image

image

image

@andrey-helldar
Copy link
Member Author

andrey-helldar commented May 14, 2021

Tests...)))

@andrey-helldar
Copy link
Member Author

andrey-helldar commented May 14, 2021

Tests are ready

image

Copy link
Member

@mohamedsabil83 mohamedsabil83 left a comment

It seems ok for me

@caouecs
Copy link
Member

caouecs commented May 20, 2021

If everybody is ok, I will do the merge ASAP

@caouecs caouecs self-assigned this May 20, 2021
@caouecs caouecs added this to the v10 milestone May 20, 2021
@andrey-helldar
Copy link
Member Author

andrey-helldar commented May 20, 2021

@caouecs, I am OK

@caouecs caouecs merged commit 8d81938 into Laravel-Lang:master May 20, 2021
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment