Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved: Parser deletes some existing tags for Laravel Jetstream #1859

Merged
merged 3 commits into from Sep 27, 2021
Merged

Solved: Parser deletes some existing tags for Laravel Jetstream #1859

merged 3 commits into from Sep 27, 2021

Conversation

andrey-helldar
Copy link
Member

Fix for #1848

@andrey-helldar andrey-helldar requested a review from a team September 24, 2021 15:25
@andrey-helldar
Copy link
Member Author

@caouecs, tests now give an error because in this PR I did not add keys to the localization files so as not to create noise.

After accepting the PR, the script will automatically do it.

Copy link
Member

@luisprmat luisprmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works! Thanks

This is after run php app/keys. The missing keys are generated successfully.

image

I know this is done by Github actions automatically but I did it manually to test.
Very good!

@luisprmat
Copy link
Member

Will this update be for a version 10.2? to avoid compatibility problems with some packages based in this one?

@luisprmat
Copy link
Member

@andrey-helldar Now I wonder if it is possible to automatically recover the translations lost in these automatic commits:

  • {locale}.json 249dad8
  • Excludes afb2189
    Do we have to do it manually or have each contributor translate again?

@andrey-helldar
Copy link
Member Author

Yes, I can do it.

@andrey-helldar andrey-helldar changed the title Solved: Parser deletes some existing tags for Laravel Jetstream WIP: Solved: Parser deletes some existing tags for Laravel Jetstream Sep 25, 2021
@andrey-helldar andrey-helldar changed the title WIP: Solved: Parser deletes some existing tags for Laravel Jetstream Solved: Parser deletes some existing tags for Laravel Jetstream Sep 25, 2021
@andrey-helldar
Copy link
Member Author

andrey-helldar commented Sep 25, 2021

@luisprmat, I returned the translated keys.

@caouecs
Copy link
Member

caouecs commented Sep 26, 2021

I merge ?

@andrey-helldar
Copy link
Member Author

@caouecs, yes. I added the key file and restored the translations.

@luisprmat
Copy link
Member

@caouecs, yes, you can merge, i think that this issue has been fully and successfully resolved

@caouecs caouecs merged commit 204af5a into Laravel-Lang:master Sep 27, 2021
@caouecs
Copy link
Member

caouecs commented Sep 27, 2021

done, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants