New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solved: Parser deletes some existing tags for Laravel Jetstream #1859
Solved: Parser deletes some existing tags for Laravel Jetstream #1859
Conversation
@caouecs, tests now give an error because in this PR I did not add keys to the localization files so as not to create noise. After accepting the PR, the script will automatically do it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this update be for a version 10.2? to avoid compatibility problems with some packages based in this one? |
@andrey-helldar Now I wonder if it is possible to automatically recover the translations lost in these automatic commits: |
Yes, I can do it. |
@luisprmat, I returned the translated keys. |
I merge ? |
@caouecs, yes. I added the key file and restored the translations. |
@caouecs, yes, you can merge, i think that this issue has been fully and successfully resolved |
done, thank you |
Fix for #1848