Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testFindClasses test #81

Merged
merged 3 commits into from Apr 14, 2019

Conversation

Projects
None yet
3 participants
@loonytoons
Copy link
Collaborator

loonytoons commented Apr 11, 2019

This test is actually failing in master currently, as well as the 5.6 branch if that change is cherry-picked into that branch.
The concern with this test failing was that the order of the returned classes was important, but given that the updated order is the current behaviour of both master and the 5.6 branch it can't actually be a problem to just switch the order in the test. Presumably this relates to update in the Symfony finder since this test was created originally.

The other changes are just a product of my OCD, updating the tabs in one of the changes that made it into master into spaces to match the rest of the file.

loonytoons added some commits Apr 11, 2019

Fix testFindClasses test
This test is actually failing in master currently, as well as the 5.6 branch if that change is cherry-picked into that branch.
The concern with this test failing was that the order of the returned classes was important, but given that the updated order is the current behaviour of both master and the 5.6 branch it can't actually be a problem to just switch the order in the test. Presumably this relates to update in the Symfony finder since this test was created originally.

@rodrigolinsr rodrigolinsr merged commit 09ea9c7 into LaravelCollective:5.7 Apr 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@@ -24,9 +24,10 @@ public function testFindInterfaces()
public function testFindClasses()
{
$classes = $this->finder->findClasses(__DIR__ . '/fixtures/finder');
sort($classes);

This comment has been minimized.

Copy link
@jpcaparas

jpcaparas Apr 14, 2019

Collaborator

@loonytoons is common to just use sort without a flag? e.g. SORT_REGULAR (the default).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.