Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add category to rooms, for suite, deluxe, standard #6

Merged
merged 2 commits into from May 25, 2019

Conversation

Projects
None yet
2 participants
@tpharaoh
Copy link

commented May 25, 2019

I thought a cool suggestion to add categories to rooms.
I tried to follow your standards, although I did rush it.

I am considering adding spatie-media to categories also

public function up()
{
Schema::table('rooms', function (Blueprint $table) {
$table->integer('category_id')->unsigned();

This comment has been minimized.

Copy link
@PovilasKorop

PovilasKorop May 25, 2019

Collaborator

@tpharaoh here I would add ->nullable() and also add a $table->foreign() to form proper DB-level foreign key and not just the column. So fix this and I will happily merge your Pull Request. Thanks!

This comment has been minimized.

Copy link
@tpharaoh

tpharaoh May 25, 2019

Author

done in latest commit

@PovilasKorop PovilasKorop merged commit 97300de into LaravelDaily:master May 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.