Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valid multicontainer access treated as invalid (and vice-versa) #166

Closed
dgarroDC opened this issue Dec 21, 2019 · 2 comments
Closed

Valid multicontainer access treated as invalid (and vice-versa) #166

dgarroDC opened this issue Dec 21, 2019 · 2 comments
Labels
bug

Comments

@dgarroDC
Copy link
Collaborator

@dgarroDC dgarroDC commented Dec 21, 2019

This doesn´t compile (Malformed statement):

data:

a is number map map
b is number map
c is number

procedure:

display a:b:c:b:0

If we replace the c with 0 it works.

Maybe the problem is here:

ldpl/src/ldpl.cpp

Line 2081 in eb14e2f

if(is_number(tokens[i]) || is_string(tokens[i])){

Should we check if the token is any scalar expression (instead of just a literal)?

I also found that this passes the LDPL to C++ stage (but throws an error compiling the C++ code because of the VAR_A[VAR_A] expression):

data:

a is number map

procedure:

display a:a
@dgarroDC dgarroDC added the bug label Dec 21, 2019
@Lartu

This comment has been minimized.

Copy link
Owner

@Lartu Lartu commented Dec 23, 2019

@dgarroDC I see this was marked as fixed in a commit. Shall I close this ticket?

@dgarroDC dgarroDC closed this in 0567ea9 Dec 24, 2019
@Lartu

This comment has been minimized.

Copy link
Owner

@Lartu Lartu commented Dec 24, 2019

Wonderful! Thank you very very very very much for fixing this! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.