Clojure 1.3.0-beta1 compatibility #98

Merged
merged 2 commits into from Jul 28, 2011

Projects

None yet

2 participants

@paraseba
Contributor

clojure-contrib is deprecated in favor of individual libraries.
c.c.sql is no longer maintained and has some serious bugs that are being
addressed in the new org.clojure/java.jdbc (see for instance
http://dev.clojure.org/jira/browse/JDBC-11)
clojure 1.3.0 requires the addition of :dynamic metadata. All these issues are
taken care in the commit. All tests are passing, regular and integration, using both
clojure 1.2.0 and 1.3.0-beta1. Using clojure 1.3.0 there is a little issue with the
mocking library used for a couple of tests.

The downside is that projects using clojureql and c.c.sql will need to change
namespaces to the new clojure.java.jdbc.

Detail:

  • No longer depend on clojure-contrib
  • c.c.sql replaced by org.clojure/java.jdbc
  • c.c.core replaced by org.clojure/core.incubator
  • c.c.mock replaced by org.clojure.contrib/mock

Tests:

  • All regular and integration tests are passing with clj 1.2.0
  • All tests which doesn't depend on the mocking library are passing with clj 1.3.0-beta1
  • I've been using this patch in a production application (postgresql) for a couple of weeks, without any problems

Comments

  • We should get rid of the mocking library which is not compatible with clj 1.3.0, we can discuss about that and I could implement the change.
  • I think we need to thing a bit more about updates and inserts, I think that currently we don't have a good API for that. I had to resort to c.j.jdbc in my application
paraseba added some commits Jul 12, 2011
@paraseba paraseba clojure 1.3.0 compatibility
clojure-contrib is deprecated in favor of individual libraries.
c.c.sql is no longer maintained and has some serious bugs that are being
addressed in the new org.clojure/java.jdbc (see for instance
http://dev.clojure.org/jira/browse/JDBC-11)
clojure 1.3.0 requires the addition of :dynamic metadata. All these issues are
taken care in the commit. All tests are passing, regular and integration, using both
clojure 1.2.0 and 1.3.0-beta1. Using clojure 1.3.0 there is a little issue with the
mocking library used for a couple of tests.

The downside is that projects using clojureql and c.c.sql will need to change
namespaces to the new clojure.java.jdbc.

Detail:

* No longer depend on clojure-contrib
** c.c.sql replaced by org.clojure/java.jdbc
** c.c.core replaced by org.clojure/core.incubator
** c.c.mock replaced by org.clojure.contrib/mock
c5f1fb7
@paraseba paraseba Use clojure.java.jdbc/prepare-statement a270eff
@paraseba
Contributor

Forget to mention: the application where I'm using this patch runs on clj 1.3.0-beta1. The only dependency this patch leaves with the old contrib style libraries is for testing, the mocking library.

@bendlas bendlas merged commit a270eff into LauJensen:master Jul 28, 2011
@bendlas
Collaborator
bendlas commented Jul 28, 2011

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment