Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for static builds with mingw-w64 compilers #218

Merged
merged 2 commits into from Feb 17, 2013

Conversation

BMBurstein
Copy link
Contributor

Fix for issue #132

@BMBurstein BMBurstein closed this May 1, 2012
@BMBurstein BMBurstein reopened this May 1, 2012
@eXpl0it3r
Copy link
Member

Would be nice if the patch gets applied, otherwise one always needs to hack the macros to get it working...

Additionally it could also get prevented/fixed by correctly linking the dependencies.

@LaurentGomila
Copy link
Member

There's no point fixing this if there's no 64-bit version of the external dependencies.

@eXpl0it3r
Copy link
Member

The MinGW-w64 project doesn't provide only a 64bit compiler, but they also provide a 32bit compiler, which has the same problem (e.g. see my Nightly Builds).
For the 32bit MinGW-w64 branch I'd have to change the path to ${STANDARD_LIBS_PATH}/i686-w64-mingw32/lib/lib${lib}.a.

@LaurentGomila
Copy link
Member

I see.

@eXpl0it3r
Copy link
Member

I've just tested this pull request and it works for all the tested compilers and see no reason for it not to work on possibly others.
I've tested the following compilers:

  • Official MinGW32, just to see that nothing breaks.
  • Visual Studio 2010, just to see that nothing breaks.
  • MinGW-w64 x86 compiler by rubenvb
  • MinGW-w64 x64 compiler by rubenvb
  • MinGW-w64 x64 TDM

Would be nice, if this could finally get integrated!

LaurentGomila added a commit that referenced this pull request Feb 17, 2013
fix for static builds with mingw-w64 compilers
@LaurentGomila LaurentGomila merged commit 274d316 into SFML:master Feb 17, 2013
@LaurentGomila
Copy link
Member

Thanks for testing it!

I merge the modifications, but the 64-bit dependencies are still missing ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants