New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piracy Check AGAIN? #940

Closed
CKrome opened this Issue Nov 20, 2017 · 34 comments

Comments

Projects
None yet
10 participants
@CKrome

CKrome commented Nov 20, 2017

Expected Behavior

It opens a prompt to select icon packs.

Actual Behavior

It says "This device has a few piracy tools installed. Please uninstall them to continue."

Steps to Reproduce

1.Install some "piracy tools"
2.Open "Settings"→"Theme"
3.Click "Icon Pack"

Environment

Device: Xiaomi Redmi Note 4 "mido"
Android version: 7.1.2
Launcher version: 1.1.0.1583
Rom: LineageOS 14.1

@reC0D3D

This comment has been minimized.

Show comment
Hide comment
@reC0D3D

reC0D3D Nov 20, 2017

Contributor

This is normal behavior. The privacy check was never removed.

Contributor

reC0D3D commented Nov 20, 2017

This is normal behavior. The privacy check was never removed.

@CKrome

This comment has been minimized.

Show comment
Hide comment
@CKrome

CKrome Nov 20, 2017

Just checked this unmerged PR, it seems that only icon packs function is restricted if user installed some piracy tools.
Also saw the discussion in reddit
I understand why you developers never remove this piracy check for some reasons. But I actually don't want to see the whole world is going to kill piracy, result in everyone has to pay a lot of money to buy things before testing them, in that case, piracy is actually try before buy.
Emmm... OK, I will fork and make my own one.

CKrome commented Nov 20, 2017

Just checked this unmerged PR, it seems that only icon packs function is restricted if user installed some piracy tools.
Also saw the discussion in reddit
I understand why you developers never remove this piracy check for some reasons. But I actually don't want to see the whole world is going to kill piracy, result in everyone has to pay a lot of money to buy things before testing them, in that case, piracy is actually try before buy.
Emmm... OK, I will fork and make my own one.

@CKrome CKrome closed this Nov 20, 2017

@divadsn

This comment has been minimized.

Show comment
Hide comment
@divadsn

divadsn Nov 20, 2017

Member

Just FYI: You can pirate apps without using those fishy apps 😉

Or just use the 48h refund period to refund the apps you've tried but don't liked.

Member

divadsn commented Nov 20, 2017

Just FYI: You can pirate apps without using those fishy apps 😉

Or just use the 48h refund period to refund the apps you've tried but don't liked.

@tvteja

This comment has been minimized.

Show comment
Hide comment
@tvteja

tvteja Jun 12, 2018

100% Truth- A launcher has no business deciding what I should use it to launch. That's my job. Launchers job is to launch my decision.

tvteja commented Jun 12, 2018

100% Truth- A launcher has no business deciding what I should use it to launch. That's my job. Launchers job is to launch my decision.

@divadsn

This comment has been minimized.

Show comment
Hide comment
@divadsn

divadsn Jun 12, 2018

Member

You can launch whatever you want, get your facts right before writing spam.

Member

divadsn commented Jun 12, 2018

You can launch whatever you want, get your facts right before writing spam.

@paphonb

This comment has been minimized.

Show comment
Hide comment
@paphonb

paphonb Jun 12, 2018

Member

100% Truth- You replies to a 7 months old issue and Lawnchair doesn’t prevent you from launching your apps.

Member

paphonb commented Jun 12, 2018

100% Truth- You replies to a 7 months old issue and Lawnchair doesn’t prevent you from launching your apps.

@tvteja

This comment has been minimized.

Show comment
Hide comment
@tvteja

tvteja Jun 12, 2018

@paphonb Lol....it doesnt matter how old...but have checked just now...still issue preset 👎

tvteja commented Jun 12, 2018

@paphonb Lol....it doesnt matter how old...but have checked just now...still issue preset 👎

@divadsn

This comment has been minimized.

Show comment
Hide comment
@divadsn

divadsn Jun 12, 2018

Member

@tvteja are you blind? The mentioned thing wasn't even merged and is now only in use to prevent illegal use of pirated iconpacks and there is a reason behind that.

Member

divadsn commented Jun 12, 2018

@tvteja are you blind? The mentioned thing wasn't even merged and is now only in use to prevent illegal use of pirated iconpacks and there is a reason behind that.

@tvteja

This comment has been minimized.

Show comment
Hide comment
@tvteja

tvteja Jun 12, 2018

@divadsn is it? then why its asking to remove pirate apps ("This device has a few piracy tools installed. Please uninstall them to continue.") its non of your bushiness

tvteja commented Jun 12, 2018

@divadsn is it? then why its asking to remove pirate apps ("This device has a few piracy tools installed. Please uninstall them to continue.") its non of your bushiness

@paphonb

This comment has been minimized.

Show comment
Hide comment
@paphonb

paphonb Jun 12, 2018

Member

No. Lawnchair doesn’t prevent you from launching apps you want. Your point is invalid.

Member

paphonb commented Jun 12, 2018

No. Lawnchair doesn’t prevent you from launching apps you want. Your point is invalid.

@divadsn

This comment has been minimized.

Show comment
Hide comment
@divadsn

divadsn Jun 12, 2018

Member

@tvteja it is our business to prevent you from abusing Lawnchair to use pirated iconpacks.
In many countries such practise would make us as a tool illegal too.

Member

divadsn commented Jun 12, 2018

@tvteja it is our business to prevent you from abusing Lawnchair to use pirated iconpacks.
In many countries such practise would make us as a tool illegal too.

@tvteja

This comment has been minimized.

Show comment
Hide comment
@tvteja

tvteja Jun 12, 2018

@paphonb Read Purpose of thread first, this is the reason i posted here

Expected Behavior
It opens a prompt to select icon packs.

Actual Behavior
It says "This device has a few piracy tools installed. Please uninstall them to continue."

tvteja commented Jun 12, 2018

@paphonb Read Purpose of thread first, this is the reason i posted here

Expected Behavior
It opens a prompt to select icon packs.

Actual Behavior
It says "This device has a few piracy tools installed. Please uninstall them to continue."

@abhijeetbohra

This comment has been minimized.

Show comment
Hide comment
@abhijeetbohra

abhijeetbohra Jun 12, 2018

Member

@paphonb But sir I want my 'launcher' to 'launch' my apps please help I'm blind.

Member

abhijeetbohra commented Jun 12, 2018

@paphonb But sir I want my 'launcher' to 'launch' my apps please help I'm blind.

@divadsn

This comment has been minimized.

Show comment
Hide comment
@divadsn

divadsn Jun 12, 2018

Member

@tvteja selecting iconpacks != launching apps

Member

divadsn commented Jun 12, 2018

@tvteja selecting iconpacks != launching apps

@tvteja

This comment has been minimized.

Show comment
Hide comment
@tvteja

tvteja Jun 12, 2018

@divadsn 100% Truth- A launcher has no business deciding what apps i use. That's my job. Launchers job is to launch my decision.

Is it fine now?

tvteja commented Jun 12, 2018

@divadsn 100% Truth- A launcher has no business deciding what apps i use. That's my job. Launchers job is to launch my decision.

Is it fine now?

@divadsn

This comment has been minimized.

Show comment
Hide comment
@divadsn

divadsn Jun 12, 2018

Member

We launch whatever you want, but we won't allow you to use our app to apply illegal iconpacks, get it.

Member

divadsn commented Jun 12, 2018

We launch whatever you want, but we won't allow you to use our app to apply illegal iconpacks, get it.

@tvteja

This comment has been minimized.

Show comment
Hide comment
@tvteja

tvteja Jun 12, 2018

@divadsn i havent used any pirated icon packs. know facts before post. As a developer like you i use many tools for my development

tvteja commented Jun 12, 2018

@divadsn i havent used any pirated icon packs. know facts before post. As a developer like you i use many tools for my development

@divadsn

This comment has been minimized.

Show comment
Hide comment
@divadsn

divadsn Jun 12, 2018

Member

@tvteja then why does it bother that you get that message? 🤔

Member

divadsn commented Jun 12, 2018

@tvteja then why does it bother that you get that message? 🤔

@tvteja

This comment has been minimized.

Show comment
Hide comment
@tvteja

tvteja Jun 12, 2018

@divadsn thats why am asking you why? and what i want to say finally is i dont have any rights to demand you. as a android lover,developer i like Lawnchair so i just trying to resolve issue..(seems not only me, i had read so many post regarding same on xda).hope you people understand

tvteja commented Jun 12, 2018

@divadsn thats why am asking you why? and what i want to say finally is i dont have any rights to demand you. as a android lover,developer i like Lawnchair so i just trying to resolve issue..(seems not only me, i had read so many post regarding same on xda).hope you people understand

@divadsn

This comment has been minimized.

Show comment
Hide comment
@divadsn

divadsn Jun 12, 2018

Member

@tvteja because of the fact that iconpacks cannot prevent the use themselves and we respect the work of every iconpack designer.

Member

divadsn commented Jun 12, 2018

@tvteja because of the fact that iconpacks cannot prevent the use themselves and we respect the work of every iconpack designer.

@tvteja

This comment has been minimized.

Show comment
Hide comment
@tvteja

tvteja Jun 12, 2018

@divadsn not only you i too respect iconpack designer and all app developers also. i know how much hard work will be there behind. but issue is i haven't used any pirated icon pack app and not sure why issue still comming
(Note: not only pirated apps i wont use any pirate apps like lucky patcher etc.. only device got rooted(systemless magisk) and u know rooting is necessary for development)

tvteja commented Jun 12, 2018

@divadsn not only you i too respect iconpack designer and all app developers also. i know how much hard work will be there behind. but issue is i haven't used any pirated icon pack app and not sure why issue still comming
(Note: not only pirated apps i wont use any pirate apps like lucky patcher etc.. only device got rooted(systemless magisk) and u know rooting is necessary for development)

@MSF-Jarvis

This comment has been minimized.

Show comment
Hide comment
@MSF-Jarvis

MSF-Jarvis Jun 12, 2018

Contributor

only device got rooted(systemless magisk) and u know rooting is necessary for development)

I build an app with over a million downloads on an unrooted Google Pixel 2 running stock software, just saying...

Contributor

MSF-Jarvis commented Jun 12, 2018

only device got rooted(systemless magisk) and u know rooting is necessary for development)

I build an app with over a million downloads on an unrooted Google Pixel 2 running stock software, just saying...

@tvteja

This comment has been minimized.

Show comment
Hide comment
@tvteja

tvteja Jun 12, 2018

@divadsn and @paphonb you people still want to keep like this then at least change string message as
""This device has a few piracy icon packs installed. Please uninstall them to continue."

tvteja commented Jun 12, 2018

@divadsn and @paphonb you people still want to keep like this then at least change string message as
""This device has a few piracy icon packs installed. Please uninstall them to continue."

@tvteja

This comment has been minimized.

Show comment
Hide comment
@tvteja

tvteja Jun 12, 2018

@MSF-Jarvis not everyone ...apps development based on requirement... if you ask mine my task involves development of networking app which required to root for test

tvteja commented Jun 12, 2018

@MSF-Jarvis not everyone ...apps development based on requirement... if you ask mine my task involves development of networking app which required to root for test

@divadsn

This comment has been minimized.

Show comment
Hide comment
@divadsn

divadsn Jun 12, 2018

Member

@tvteja no, we look after piracy apps, not after iconpacks, get the point.

Member

divadsn commented Jun 12, 2018

@tvteja no, we look after piracy apps, not after iconpacks, get the point.

@MSF-Jarvis

This comment has been minimized.

Show comment
Hide comment
@MSF-Jarvis

MSF-Jarvis Jun 12, 2018

Contributor

development of networking app which required to root for test

I intern at WireGuard and develop their Android app on that same unrooted phone 🙂

Contributor

MSF-Jarvis commented Jun 12, 2018

development of networking app which required to root for test

I intern at WireGuard and develop their Android app on that same unrooted phone 🙂

@tvteja

This comment has been minimized.

Show comment
Hide comment
@tvteja

tvteja Jun 12, 2018

@MSF-Jarvis Great and Appreciated,. Not everyone like you. here i cant share my task but what i want to say is rooting is necessary for that

tvteja commented Jun 12, 2018

@MSF-Jarvis Great and Appreciated,. Not everyone like you. here i cant share my task but what i want to say is rooting is necessary for that

@paphonb

This comment has been minimized.

Show comment
Hide comment
@paphonb

paphonb Jun 12, 2018

Member

@tvteja I develop Xposed modules and I understand that root might be required. But I can’t imagine any situation that you’d need piracy tools to develop.

Member

paphonb commented Jun 12, 2018

@tvteja I develop Xposed modules and I understand that root might be required. But I can’t imagine any situation that you’d need piracy tools to develop.

@tvteja

This comment has been minimized.

Show comment
Hide comment
@tvteja

tvteja Jun 12, 2018

@paphonb Thanks but please try to get the my point. telling again i haven't used any pirated apps ...only device got rooted.

tvteja commented Jun 12, 2018

@paphonb Thanks but please try to get the my point. telling again i haven't used any pirated apps ...only device got rooted.

@xdevs23

This comment has been minimized.

Show comment
Hide comment
@xdevs23

xdevs23 Jun 12, 2018

If you think your launcher does not match your expectations, please consider using a different launcher or implement the desired functionality yourself. If the developers decide to implement measures against piracy then that's what you get. The point is not what the job of a launcher is. You decide which launcher you use and thus end of discussion.

xdevs23 commented Jun 12, 2018

If you think your launcher does not match your expectations, please consider using a different launcher or implement the desired functionality yourself. If the developers decide to implement measures against piracy then that's what you get. The point is not what the job of a launcher is. You decide which launcher you use and thus end of discussion.

@fonix232

This comment has been minimized.

Show comment
Hide comment
@fonix232

fonix232 Jun 12, 2018

Member

@tvteja just get over it. Lawnchair will not allow possible piracy (i.e. using icon packs) when there's a chance of the icon pack being pirated, by using a third party tool (like Lucky Patcher), it WILL disable the icon pack feature.

Go and look into the code, the list of apps triggering it are pretty clearly stated. And I don't see how you'd need Lucky Patcher, or Uret patcher - which are pretty much the only packages currently blacklisted. So either remove these apps - because you don't need them for development at all - or stop fucking whining.

Member

fonix232 commented Jun 12, 2018

@tvteja just get over it. Lawnchair will not allow possible piracy (i.e. using icon packs) when there's a chance of the icon pack being pirated, by using a third party tool (like Lucky Patcher), it WILL disable the icon pack feature.

Go and look into the code, the list of apps triggering it are pretty clearly stated. And I don't see how you'd need Lucky Patcher, or Uret patcher - which are pretty much the only packages currently blacklisted. So either remove these apps - because you don't need them for development at all - or stop fucking whining.

@tvteja

This comment has been minimized.

Show comment
Hide comment
@tvteja

tvteja Jun 13, 2018

All, thanks for your reply. Let's make end of this discussion ☺️

tvteja commented Jun 13, 2018

All, thanks for your reply. Let's make end of this discussion ☺️

@arpitnnd

This comment has been minimized.

Show comment
Hide comment
@arpitnnd

arpitnnd Jun 13, 2018

@tvteja You had been trying to 'make a point' all this time and you don't even have one.
Let me simplify things for you:
Lawnchair doesn't stop you from launching anything.
Lawnchair stops you from using an icon pack if you have certain piracy apps installed.
Being a developer you should be capable enough to go through a bit of code & figure of which apps are blacklisted.
Nobody needs piracy tools for development of anything other than those tools themselves.
If you actually aren't using any blacklisted stuff you could have continued this conversation with a very different approach.

I don't even use Lawnchair but, could still figure the first two out from the comments. Why can't you?

@divadsn Maybe, to avoid a commotion like this, just show a pop-up with a list of blacklisted apps on first icon pack selection attempt.

arpitnnd commented Jun 13, 2018

@tvteja You had been trying to 'make a point' all this time and you don't even have one.
Let me simplify things for you:
Lawnchair doesn't stop you from launching anything.
Lawnchair stops you from using an icon pack if you have certain piracy apps installed.
Being a developer you should be capable enough to go through a bit of code & figure of which apps are blacklisted.
Nobody needs piracy tools for development of anything other than those tools themselves.
If you actually aren't using any blacklisted stuff you could have continued this conversation with a very different approach.

I don't even use Lawnchair but, could still figure the first two out from the comments. Why can't you?

@divadsn Maybe, to avoid a commotion like this, just show a pop-up with a list of blacklisted apps on first icon pack selection attempt.

@abhijeetbohra

This comment has been minimized.

Show comment
Hide comment
@abhijeetbohra

abhijeetbohra Jun 13, 2018

Member

@arpitnnd Thanks for adding shit to this issue which is irrelevant and not even an issue. All the icon pack developers aren't working for free for days and nights investing numerous hours while making icon packs for users. If you have piracy tools installed, Lawnchair WILL stop you from applying the icon packs even if you use the piracy tools for stuff like blocking ads or making it a system apps. Google the alternate solutions for both of them if that's the case. @deletescape please close this issue as it's completely irrelevant and doesn't belong here at all. Thanks.

Member

abhijeetbohra commented Jun 13, 2018

@arpitnnd Thanks for adding shit to this issue which is irrelevant and not even an issue. All the icon pack developers aren't working for free for days and nights investing numerous hours while making icon packs for users. If you have piracy tools installed, Lawnchair WILL stop you from applying the icon packs even if you use the piracy tools for stuff like blocking ads or making it a system apps. Google the alternate solutions for both of them if that's the case. @deletescape please close this issue as it's completely irrelevant and doesn't belong here at all. Thanks.

@LawnchairLauncher LawnchairLauncher locked as too heated and limited conversation to collaborators Jun 13, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.