New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option in preferences to animate alternative clock apps #756

Merged
merged 1 commit into from Sep 25, 2017

Conversation

Projects
None yet
2 participants
@divadsn
Member

divadsn commented Sep 25, 2017

This should finally allow users to enable this "hidden" option when they're using stock OEM apps.
Now it should animate the clock app on Samsung and Xiaomi devices as well.

TODO: Find a regex or way to add all clock apps (maybe by looking up clock providers?)

Add option in preferences to animate alternative clock apps
This should finally allow users to enable this "hidden" option when they're using stock OEM apps.
Now it should animate the clock app on Samsung and Xiaomi devices as well.

TODO: Find a regex or way to add all clock apps (maybe by looking up clock providers?)

@divadsn divadsn merged commit a40a33c into LawnchairLauncher:alpha Sep 25, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@divadsn

This comment has been minimized.

Member

divadsn commented Sep 25, 2017

Sorry @deletescape that I added two more strings to translate 😛

@Younes-L

This comment has been minimized.

Younes-L commented on 2afb19c Sep 26, 2017

hello, is this supposed to animate the stock android clock as well ?
clock v4.5.2

thanks :)

This comment has been minimized.

Member

divadsn replied Sep 26, 2017

This comment has been minimized.

Younes-L replied Sep 27, 2017

@divadsn

package : com.android.deskclock

activity : com.android.deskclock.DeskClock

app version: 4.5.2 , with the old icon, this one

↑ maybe that's why it's not supported ? I only saw the G clock with new icon animated (icon with the red hand)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment