New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode insensitive comparison in All Apps search #813

Merged
merged 3 commits into from Oct 11, 2017

Conversation

Projects
None yet
2 participants
@Rawi666
Contributor

Rawi666 commented Oct 8, 2017

For searching replace any non-ascii characters to theirs ascii equivalents.
E.g. in Polish: "Menadżer telefonu" can now be found using "menadzer" or "menadżer" or "dzer" or "dżer"

@Rawi666 Rawi666 force-pushed the Rawi666:unicode_search branch from 07049df to 86b2434 Oct 8, 2017

@divadsn divadsn requested review from fonix232, paphonb, deletescape and divadsn Oct 11, 2017

@divadsn

divadsn requested changes Oct 11, 2017 edited

I don't like the way you replace the speicial unicode characters (umlauts) using String#replace for every you have found, I think there is a better and more effective way to achieve this.

Edit: Actually there is a better way, have you tried that?
https://stackoverflow.com/a/3322174

@divadsn

This comment has been minimized.

Member

divadsn commented Oct 11, 2017

As we came to a decision, there is no need in my opinion to replace Greek and Russian letters, as they have their own keyboard layouts, the original idea was also to avoid SMS size limitations, while we don't have such limitations when it comes to the search bar.

@divadsn

This comment has been minimized.

Member

divadsn commented Oct 11, 2017

There is also actually no need to add a entire library for one usage 😄

@divadsn divadsn force-pushed the Rawi666:unicode_search branch 2 times, most recently from 170a68a to 8aeca76 Oct 11, 2017

@divadsn divadsn force-pushed the Rawi666:unicode_search branch from 8aeca76 to 1067665 Oct 11, 2017

@divadsn divadsn merged commit 51a99cf into LawnchairLauncher:alpha Oct 11, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment