Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between release and debug via applicationIdSuffix & label #3255

Merged

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Jan 17, 2023

Description

To divide the debug with the release, easy to test the debug app instead of covering the release one installed.

Type of change

✅ General change (non-breaking change that doesn't fit the below categories like copyediting)
❌ Bug fix (non-breaking change which fixes an issue)
❌ New feature (non-breaking change which adds functionality)
❌ Breaking change (fix or feature that would cause existing functionality to not work as expected)

@Goooler Goooler changed the title Add applicationIdSuffix for debug mode Add applicationIdSuffix for debug mode Jan 17, 2023
@Goooler
Copy link
Member Author

Goooler commented Jan 17, 2023

One more thing, if we should use Lawnchair debug as the app name in debug mode?

Comment on lines -21 to -22
<!-- Application name -->
<string name="derived_app_name" translatable="false">Quickstep</string>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove this due to the res conflicts.

@Goooler Goooler changed the title Add applicationIdSuffix for debug mode Distinguish between release and debug via applicationIdSuffix & label Jan 18, 2023
@Goooler Goooler merged commit 9d623f0 into LawnchairLauncher:12.1-dev Jan 18, 2023
@Goooler Goooler deleted the add_app_id_suffix_on_debug branch January 18, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants