Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the bitmap lookup #455

Merged
merged 1 commit into from
Apr 6, 2024
Merged

Optimize the bitmap lookup #455

merged 1 commit into from
Apr 6, 2024

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented Apr 6, 2024 •
edited
Loading

Why are these changes needed?

This reduces number of RPC calls from 2*N to 2 (N is num of nonsigners, so can be up to 100x at the current scale of network).

Tested:

  • No more rate limiting issue (at the same RPC capacity)
  • Performance improved by about 2x (from about 3s to 1.5s for the 48h query)

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@jianoaix jianoaix merged commit b57478e into Layr-Labs:master Apr 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pschork pschork pschork approved these changes

@0x0aa0 0x0aa0 Awaiting requested review from 0x0aa0

@dmanc dmanc Awaiting requested review from dmanc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jianoaix @pschork