-
Notifications
You must be signed in to change notification settings - Fork 453
docs: slashing factors rounding #1089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
0xClandestine
merged 2 commits into
slashing-magnitudes-fixes
from
docs/slashing-factors-rounding
Feb 13, 2025
Merged
docs: slashing factors rounding #1089
0xClandestine
merged 2 commits into
slashing-magnitudes-fixes
from
docs/slashing-factors-rounding
Feb 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypatil12
approved these changes
Feb 12, 2025
eigenmikem
approved these changes
Feb 12, 2025
ddcb034 to
f75722e
Compare
ypatil12
pushed a commit
that referenced
this pull request
Feb 19, 2025
* docs: slashing factors rounding * chore: forge fmt
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* docs: slashing factors rounding * chore: forge fmt
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* docs: slashing factors rounding * chore: forge fmt
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* docs: slashing factors rounding * chore: forge fmt
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* docs: slashing factors rounding * chore: forge fmt
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* docs: slashing factors rounding * chore: forge fmt
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* docs: slashing factors rounding * chore: forge fmt
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* docs: slashing factors rounding * chore: forge fmt
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* docs: slashing factors rounding * chore: forge fmt
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* docs: slashing factors rounding * chore: forge fmt
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* docs: slashing factors rounding * chore: forge fmt
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* docs: slashing factors rounding * chore: forge fmt
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* docs: slashing factors rounding * chore: forge fmt
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* docs: slashing factors rounding * chore: forge fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Fixes an issue where rounding in
slashingFactorcalculations can result in a factor of zero, causing stakers to lose all their withdrawable shares under specific edge cases. This can be exploited by malicious operators through intentional self-slashing and small beacon chain penalties. (EGSL-16)Modifications:
slashingFactorwhenoperatorMaxMagnitudeandbeaconChainSlashingFactorare extremely small.Implemented frontend warnings for stakers when delegating to operators with extremely lowmaxMagnitude, helping mitigate potential exploits.Result:
Preventative warnings to stakers to avoid delegation to potentially malicious or risky operators.