Skip to content

Conversation

@0xClandestine
Copy link
Member

Motivation:

Fixes an issue where rounding in slashingFactor calculations can result in a factor of zero, causing stakers to lose all their withdrawable shares under specific edge cases. This can be exploited by malicious operators through intentional self-slashing and small beacon chain penalties. (EGSL-16)

Modifications:

  • Added documentation note informing users of the potential rounding issue with slashingFactor when operatorMaxMagnitude and beaconChainSlashingFactor are extremely small.
  • Implemented frontend warnings for stakers when delegating to operators with extremely low maxMagnitude, helping mitigate potential exploits.

Result:

  • Increased transparency on edge cases that could lead to loss of withdrawable shares.
  • Preventative warnings to stakers to avoid delegation to potentially malicious or risky operators.

@0xClandestine 0xClandestine changed the title Docs/slashing factors rounding docs: slashing factors rounding Feb 12, 2025
@0xClandestine 0xClandestine changed the base branch from dev to slashing-magnitudes-fixes February 12, 2025 17:34
@0xClandestine 0xClandestine force-pushed the docs/slashing-factors-rounding branch from ddcb034 to f75722e Compare February 13, 2025 14:39
@0xClandestine 0xClandestine added the ⚖️ Audit Fix Audit-related fixes. label Feb 13, 2025
@0xClandestine 0xClandestine merged commit 89d477b into slashing-magnitudes-fixes Feb 13, 2025
11 checks passed
@0xClandestine 0xClandestine deleted the docs/slashing-factors-rounding branch February 13, 2025 15:37
ypatil12 pushed a commit that referenced this pull request Feb 19, 2025
* docs: slashing factors rounding

* chore: forge fmt
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
* docs: slashing factors rounding

* chore: forge fmt
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
* docs: slashing factors rounding

* chore: forge fmt
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
* docs: slashing factors rounding

* chore: forge fmt
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
* docs: slashing factors rounding

* chore: forge fmt
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
* docs: slashing factors rounding

* chore: forge fmt
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
* docs: slashing factors rounding

* chore: forge fmt
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
* docs: slashing factors rounding

* chore: forge fmt
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
* docs: slashing factors rounding

* chore: forge fmt
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
* docs: slashing factors rounding

* chore: forge fmt
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
* docs: slashing factors rounding

* chore: forge fmt
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
* docs: slashing factors rounding

* chore: forge fmt
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
* docs: slashing factors rounding

* chore: forge fmt
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
* docs: slashing factors rounding

* chore: forge fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚖️ Audit Fix Audit-related fixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants