feat: remove SemVerMixin + add ProtocolRegistry
#1639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xClandestine
force-pushed
the
perf/codesize
branch
from
926a3f8 to
01f2730
Compare
0xClandestine
changed the base branch from
main
to
release-dev/slashing-ux-improvements
0xClandestine
force-pushed
the
perf/codesize
branch
from
01f2730 to
e6e13c2
Compare
0xClandestine
changed the base branch from
release-dev/slashing-ux-improvements
to
refactor/split-alm
**Motivation:** We want to consolidate semver logic into a single purpose built contract. **Modifications:** - Removed `SemVerMixin` import from all contracts. **Result:** More codesize savings.
0xClandestine
force-pushed
the
perf/codesize
branch
from
e6e13c2 to
5e79174
Compare
0xClandestine
changed the title
SemVerMixin + add ProtocolRegistry
0xClandestine
changed the title
SemVerMixin + add ProtocolRegistrySemVerMixin + add ProtocolRegistry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We want to reduce codesize so there's room for future functionality.
Modifications:
SemVerMixinimports, updated tests, scripts, etc.ProtocolRegistrywhich now tracks semver on a per contract basis set by owner..length == .lengthchecks can be removed as the compiler already handles them.Result:
Codesize savings.