Skip to content

Conversation

@ClemCornet
Copy link
Contributor

@ClemCornet ClemCornet commented Jul 7, 2021

Description

  • Adding LcRadio & LcRadioGroup components to the library
  • Adding stories and unit tests for both

Type of change

Please delete options that are not relevant.

  • Feature

Checklist:

  • My code follows the style guidelines of this project (tailwind class...)
  • I have performed a self-review of my own code (no:console.log, no:debugger)
  • I have commented my code, in hard-to-understand areas
  • I have sorted html attributes, props, wording by ascending order
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Existing unit tests pass locally with my changes
  • I have only the necessary commit(s) and they follow the correct template name

@ClemCornet ClemCornet added the WIP Work in progress label Jul 7, 2021
@shortcut-integration
Copy link

@ClemCornet ClemCornet changed the title feat(LcRadio): [ch5583] WIP(part1) create lcradio component feat(LcRadio): [ch5583] LcRadio component Jul 8, 2021
@ClemCornet ClemCornet force-pushed the ch5583/lcradio-component branch 3 times, most recently from 94b418f to 4d0684b Compare July 9, 2021 15:15
@ClemCornet ClemCornet force-pushed the ch5583/lcradio-component branch from 4d0684b to 9b1197d Compare July 9, 2021 15:28
@ClemCornet ClemCornet added review and removed WIP Work in progress labels Jul 9, 2021
Copy link
Contributor

@Flo2315 Flo2315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il faut pas oublier d'ajouter le composant dans le README ;)

@Flo2315 Flo2315 added question Further information is requested rejected Changes are requested and removed review labels Jul 12, 2021
@ClemCornet ClemCornet added review and removed question Further information is requested rejected Changes are requested labels Jul 12, 2021
@ClemCornet ClemCornet force-pushed the ch5583/lcradio-component branch from 678b5ea to 207e8cc Compare July 12, 2021 12:51
@ClemCornet ClemCornet force-pushed the ch5583/lcradio-component branch from 207e8cc to b8c02ac Compare July 12, 2021 13:16
@ClemCornet ClemCornet force-pushed the ch5583/lcradio-component branch from b8c02ac to 9b79c4a Compare July 12, 2021 13:20
@Flo2315 Flo2315 merged commit 91363c5 into dev Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants