Skip to content

chore(all): [ch7233] organize components by directory #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Flo2315 merged 2 commits into from
Jul 13, 2021
Merged

chore(all): [ch7233] organize components by directory #30

Flo2315 merged 2 commits into from
Jul 13, 2021

Conversation

@Flo2315
Copy link
Contributor

@Flo2315 Flo2315 commented Jul 9, 2021 •
edited
Loading

  • Organisation des composants par dossier pour une meilleur lisibilité.
  • Fix de la storie LcTooltip (car elle fonctionné pas, le tooltip ne s'affiché jamais)
  • Ajout des stories LcTooltip pour montré différents cas du tooltip
  • Ajout des events dans le LcInput (pour voir les actions, update/focusOut)
  • Déplacer les validators et les types dans les dossiers des composants

@shortcut-integration
Copy link

shortcut-integration bot commented Jul 9, 2021

This pull request has been linked to Clubhouse Story #7233: Library | Séparer composant par dossier.

@Flo2315 Flo2315 added review WIP Work in progress and removed review labels Jul 9, 2021
@Flo2315 Flo2315 force-pushed the ch7233/organize-components branch from a092d9d to d9eca96 Compare July 9, 2021 10:40
@Flo2315 Flo2315 added review and removed WIP Work in progress labels Jul 9, 2021
@Flo2315 Flo2315 force-pushed the ch7233/organize-components branch from d9eca96 to 89e731e Compare July 9, 2021 11:42
@Flo2315 Flo2315 force-pushed the ch7233/organize-components branch from 89e731e to b5bab03 Compare July 12, 2021 13:40
@ClemCornet ClemCornet self-requested a review July 12, 2021 14:42
ClemCornet
ClemCornet reviewed Jul 12, 2021
View reviewed changes
@ClemCornet ClemCornet added rejected Changes are requested and removed review labels Jul 12, 2021
@Flo2315 Flo2315 added review and removed rejected Changes are requested labels Jul 13, 2021
@Flo2315
Copy link
Contributor Author

Flo2315 commented Jul 13, 2021

Je merge, car je vais avancé sur les tests des anciens composants, ça sera plus simple avec l'organisation par dossier pour éviter d'avoir trop de conflit par la suite
Si on trouve une solution pour les @ on corrigera ça apres.

@Flo2315 Flo2315 merged commit 60eff28 into dev Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ClemCornet ClemCornet ClemCornet left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Flo2315 @ClemCornet