Skip to content

Conversation

@danielpza
Copy link
Member

@danielpza danielpza commented Apr 6, 2020

It seems to be an issue with the latest version of typescript, the option isTypeOnly was not present in previous version and that would cause errors see #48.

@danielpza danielpza changed the title fix: including types in resulting code fix: type only imports not deleted Apr 6, 2020
@dimikot
Copy link

dimikot commented May 4, 2020

Unfortunately the effect is still there, here is a minimal repro code:
https://github.com/DmitryKoterov/typescript-transform-paths-bug

image

after npx ttsc (the code of this PR is applied):

image

@danielpza
Copy link
Member Author

thanks for confirming @DmitryKoterov, yet I don't think I'll be able to work on this for a while, so anyone is free and welcome to try to tackle this issue

@dimikot
Copy link

dimikot commented May 5, 2020

Oh no, hope it’s not related to the pandemic...

Are you keen on accepting pull requests? I think I’ll anyway need to fork a couple of libraries eventually (this one and typescript-is) to implement some missing features.

@danielpza
Copy link
Member Author

Oh no, hope it’s not related to the pandemic...

no, it's not related to the pandemic, sorry if it sounded like that, just generally busy with other affairs.

Are you keen on accepting pull requests? I think I’ll anyway need to fork a couple of libraries eventually (this one and typescript-is) to implement some missing features.

Yeah I'll still be monitoring issues and PRs, and do according testing/merging for PRs.

@nonara
Copy link
Collaborator

nonara commented Sep 18, 2020

Closing for housekeeping - should be addressed with v2

@nonara nonara closed this Sep 18, 2020
@danielpza danielpza deleted the fix-errors branch September 18, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants