Support external resource packs

[terrarier2111]

This is also a nice to have feature, but low prio

[PureTryOut]

A nice bonus would be to eventually ship out of the box with a resource pack with some open-source license. Then when offline play is implemented, you can play Leafish completely without having an account from Microsoft. I have nothing against buying the game, but I do have a problem with needing a Microsoft account to play so having this fully FOSS client combined with a fully FOSS resource pack by default that allows offline play would be awesome.

Of course, the default Minecraft resource pack should still be usable and probably used by default when not playing in offline mode.

[terrarier2111]

You could also take a look at this: https://github.com/InventivetalentDev/minecraft-assets

[PureTryOut]

Nice, that at least allows people without Microsoft accounts to still use the default Minecraft resource pack. You can't ship that by default though, it's illegal and a very good way to get a cease and desist notice 😉

I'm not sure you're even allowed to link to it in any code or README.

[terrarier2111]

But we can link to the github page and download it on the first start

[PureTryOut]

No and yes but no.

IANAL but I would very much recommend not linking or recommending it at all. People can recommend it on a "mouth by mouth" basis as we say in the Netherlands, but I would recommend no official Leafish documentation or code to link to it. Let's not get into legal battles with Microsoft when we can prevent it. You can clean-room reverse engineer code but you can't do the same with art (textures, music, etc), so alternatives need to be made for that.

As for downloading it on first start, yes but only when logged in with a Microsoft account that owns the game and only from official Microsoft sources. I believe that is what happens now and it should remain like that.

[Z2Up1UwcaYOyZq]

shout out to #47

[iceiix]

A nice bonus would be to eventually ship out of the box with a resource pack with some open-source license.

Looked into open source texture packs a while back. TrueCraft uses the Pixeludi pack: https://github.com/ddevault/TrueCraft/tree/master/TrueCraft.Client/Content - but they only support up to 1.7.3 beta (2011), and in the older texture atlas format. Before Pixeludi they were using https://github.com/deathcap/ProgrammerArt which supports blocks and items up to 1.9 (in either newer "texture packs" and "resource packs" zips, or the old atlas pngs) but is not the most visually appealing, mostly only suitable as a placeholder. A fully complete, updated, and decently looking OSS resource pack would be very nice indeed, I'm looking for one too (but have yet to find any).

[PureTryOut]

Not the most visual appealing indeed, I'm not a fan at least haha. Preferably something is used that keeps the original feel of the game.

It seems most resourcepacks out there are proprietary or at least not freely licensed, quite disappointing.