Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chroma-adjust rather than per-channel clip #3

Merged
merged 1 commit into from
Apr 4, 2020

Conversation

tabatkins
Copy link
Contributor

Rather than per-channel clipping for out-of-gamut colors, which can change the hue and lightness unpredictably, adjust chroma until it's on the gamut boundary.

…hange the hue and lightness unpredictably, adjust chroma until it's on the gamut boundary.
@LeaVerou LeaVerou merged commit 9a7e853 into LeaVerou:master Apr 4, 2020
@LeaVerou
Copy link
Owner

LeaVerou commented Apr 4, 2020

Thanks, merged!

@imkremen
Copy link

But now it's not LCH. Now it's like HSLuv (HSLab?)

@LeaVerou
Copy link
Owner

Huh? The rendering intent does not define a color space.

@imkremen
Copy link

It's not about color space (sRGB, P3), it's about color model.
In practice, with this chroma adjustment we will get the new type of color model (just imagine color cylinder). If you look at popular color libraries you will see that all of them use clipping.
I understand problem with clipping, but HSLuv from this point looks like better solution.

@tabatkins
Copy link
Contributor Author

I'm sorry, but everything you've said here is wrong. Rendering intent has nothing to do with color space (which is what HSLuv is). Clipping vs chroma-adjustment vs whatever is a totally independent decision for how you handle outputting to a smaller color space.

Popular color libraries may do channel clipping (in sRGB after conversion!), but that just means they're doing bad gamut reduction because it's cheaper/simpler.

@imkremen
Copy link

Sorry for confusing. Yes, you are totally right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants