Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint, use src, update deps, use a utils module #1

Closed
wants to merge 3 commits into from
Closed

Eslint, use src, update deps, use a utils module #1

wants to merge 3 commits into from

Conversation

dgrammatiko
Copy link

This PR is:

  • updating the dependencies to their latest versions
  • dropping jshint in favour of eslint
  • using the web-test-runner instead of the hihat
  • move the source files in a src directory and
  • splitting the source to essentially the class and a file named utils (this fixed Safari 🤷‍♂️)
  • use both the default and a named export dragula

All tests are still green and the script works on all major browsers

If this is way too many changes for one PR I could split it in a few more specific ones.

BTW thanks for all the work you've already done here!

@netlify
Copy link

netlify bot commented Jul 5, 2022

Deploy Preview for dragula2 ready!

Name Link
🔨 Latest commit 338cbf1
🔍 Latest deploy log https://app.netlify.com/sites/dragula2/deploys/62c425befa7e2c000972e869
😎 Deploy Preview https://deploy-preview-1--dragula2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant