Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS support? #2

Closed
Ambient-Impact opened this issue Feb 8, 2017 · 4 comments
Closed

HTTPS support? #2

Ambient-Impact opened this issue Feb 8, 2017 · 4 comments

Comments

@Ambient-Impact
Copy link

I love how simple and effective this is, but I'm wondering if you're planning on supporting HTTPS sites? As it is, I can load the default sites provided, and http://example.com, but whenever I try to load any site that is only accessible via HTTPS (like my own site, or mozilla.org), I just get a blank frame. I'm using Firefox Developer Edition 53.0a2 (2017-02-07) (32-bit) with the tracking protection Test Pilot addon disabled for your site, and uBlock Origin also disabled on your site, but those seem to have made no difference. Maybe this is security thing?

@Ambient-Impact
Copy link
Author

Update: Chrome 57.0.2987.21 beta (64-bit) does the same thing, but Edge 38.14393.0.0 actually gives me a reason (while still not showing me the frame contents):
duoload

I wonder if this is unfixable, or if there is some way around this?

@felansu
Copy link

felansu commented Feb 9, 2017

@LeaVerou
Copy link
Owner

LeaVerou commented Feb 9, 2017

It loads https just fine, for example try changing the lea.verou.me URL to https.
The reason duoload itself doesn't use https is so that it can be used to test both http and https sites.
As the error message in your screenshot is saying, "the publisher doesn't allow it to be displayed in an iframe" = X-Frame-Options is in effect. There's no way around this, duoload just can't be used for sites with that header.

@LeaVerou LeaVerou closed this as completed Feb 9, 2017
@Ambient-Impact
Copy link
Author

My bad, thanks for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants