Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the build script #15

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Simplify the build script #15

merged 1 commit into from
Nov 20, 2020

Conversation

dgrammatiko
Copy link
Contributor

  • Using the building promises for the fs package

@LeaVerou
Copy link
Owner

🤯🤯🤯
Whoa, mind blown! Thank you!!

But which version of Node does this require?

@dgrammatiko
Copy link
Contributor Author

Oops I should have added that requires v10.23.0 https://nodejs.org/dist/latest-v10.x/docs/api/fs.html

@LeaVerou LeaVerou merged commit c03abe4 into LeaVerou:master Nov 20, 2020
@LeaVerou
Copy link
Owner

That's fine. Thanks again, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants