Use Object.entries for iteration
#59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because manual formatting is painful.
This fixes an problem related to parsing CSS escapes and removes some redundant matching done during restoration of strings and parentheses. Fixed: #30
`Tokens` is not semantic as it doesn't represent several tokens, but just a single one.
LeaVerou
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
Thanks, LGTM! This would also have been fine as a direct commit.
The reason I used a for..in loop originally was to avoid the extra array creation and extra iteration that Objet.entries() introduces, but this kind of micro-optimization is probably not needed anymore (especially for such a small data structure and such small inputs) so I should get over myself 😄
|
Closed in 1599bce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.