Broken when stylesheet URL contains RegExp chars like + #81

Closed
gotcha opened this Issue Jun 20, 2012 · 15 comments

Projects

None yet

2 participants

@gotcha
Contributor
gotcha commented Jun 20, 2012

Behavior RegExp is broken:

SyntaxError: Invalid regular expression /bla/: Nothing to repeat

Base URL needs to be escaped before being used in a RegExp.

@LeaVerou
Owner

Gah, right. Confirmed, thanks! This should be pretty easy to fix, provided I get some time to address it.

@gotcha gotcha added a commit to gotcha/prefixfree that referenced this issue Jun 20, 2012
@gotcha gotcha Base URL should be RegExp escaped :
Fix for issue #81
1b6d3d8
@LeaVerou
Owner

Fixed, so closed. Thanks again :)

@LeaVerou LeaVerou closed this Jun 20, 2012
@gotcha
Contributor
gotcha commented Jun 20, 2012

How does the fix gets included in prefixfree.min.js ?

@LeaVerou
Owner

It doesn’t — somebody has to manually do it.

@gotcha
Contributor
gotcha commented Jun 20, 2012

Which minifier do you use ?

This way, I can do it !

@LeaVerou
Owner

I alternate between uglifyJS and Closure Compiler. But any other good minifier is fine.

@gotcha
Contributor
gotcha commented Jun 20, 2012

Is there a convention for version numbers like 1.0.2 and 1.0.6 ?

When do you bump those ?

@LeaVerou
Owner

When it feels right.

I guess you may bump the StyleFix version. Not the prefixfree version though.

@gotcha
Contributor
gotcha commented Jun 20, 2012

In the Zope/Plone community, we include the changelog in the READMEs.
This way, it is much easier to know which version you need to get a fix for a given bug.

@LeaVerou
Owner

What’s the point of that? Can’t somebody just check the commits?

@gotcha
Contributor
gotcha commented Jun 20, 2012

If I do not follow closely a project, it is much easier to scan a CHANGELOG than to check each commit.

@LeaVerou
Owner

This sounds like a fix to a badly organized commits history. Why not just try to keep the commit history as neat as possible? (not saying I manage to, but I try...)

@gotcha
Contributor
gotcha commented Jun 20, 2012

When the CHANGELOG is available, it is much easier to get a hint if a bug I hit has already been solved in a later release.

But, I do not want to argue/troll. It was just a suggestion.

@LeaVerou
Owner

I’m not against the idea, I’m just afraid it will get out of sync very quickly. I wish there was a way to do it automatically through the commits history (e.g. highlight the most important commits or something)

@gotcha
Contributor
gotcha commented Jun 20, 2012

It is true that it takes a while until it is a habit. Nevertheless, once a community gets used, it really brings value. I'll try to make a change log that makes sense and propose it as a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment