Edit/delete handler bug. #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 18, 2013 17:32
when another handler is clicked on.
Add draw:deletestart and draw:deletestop events.
|
Awesome! One small issue, could you please pull in the Leaflet.draw upstream to get all changes in the last 3 months so this PR can be automatically merged. There might be conflicts since you fork is out of date. |
added 2 commits
December 18, 2013 22:06
Conflicts: src/edit/EditToolbar.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit:
When in edit/delete mode, revertLayers has to be called when another handler is clicked on.
To reproduce in http://leaflet.github.io/Leaflet.draw/
-Draw two markers
-Delete one but do not click save/cancel
-Click edit button.
The marker is deleted even though the change was not saved.
Second commit:
-draw:deletestart and draw:deletestop are fired in delete handler instead of draw:editstart and draw:editstop.
-enable and disable functions are reshaped so that a handler cannot be activated while the other is still active.
This is useful when drawLayer has to be updated in some way when entering delete mode and in another way when entering edit mode.