PolyEdit small bug (or feature) when removing markers

[Svad]

Hi, guys.
I found an interesting issue when removing two markers from the same end of polyline.
Try to delete two markers here: http://jsfiddle.net/Wb6Pp/2/ You will see "middle" marker floating in sea.
Is this right behavior?

[danzel]

Definitely not intended behaviour!
Very strange, will take a look later today.

Remove bottom right, then top right. (Or bottom left then top left)

[Svad]

I solved this so (in _onMarkerClick:115):

if(!marker._next) {
//if this is the last marker - delete link on it in it's _prev marker
    delete marker._prev._next;    
} else if(!marker._prev) {
//if this is the first - delete link on it in it's _next marker
    delete marker._next._prev;
} else {
// Check existence of previous and next markers since they wouldn't exist for edge points on the polyline
    this._createMiddleMarker(marker._prev, marker._next);
    this._updatePrevNext(marker._prev, marker._next);
}

[Svad]

I solved this so (in _onMarkerClick:115):

if(!marker._next) {
//if this is the last marker - delete link on it in it's _prev marker
    delete marker._prev._next;    
} else if(!marker._prev) {
//if this is the first - delete link on it in it's _next marker
    delete marker._next._prev;
} else {
// Check existence of previous and next markers since they wouldn't exist for edge points on the polyline
    this._createMiddleMarker(marker._prev, marker._next);
    this._updatePrevNext(marker._prev, marker._next);
}

P.S. Sorry, accidentally close issue.

[danzel]

I've pushed up a fix for this here: https://github.com/danzel/Leaflet/tree/polyedit

If you could please grab it and verify everything is fixed then I'll pull it in.

It is implemented a little different to your patch above, we also need to update _middleLeft/_middleRight otherwise the markers still think they have neighbours which can cause breaks when moving markers after deleting some.

Thanks!

[Svad]

Works well, thank you!
Should i close issue?

[danzel]

Yep, have merged in that fix, thanks for testing!
I'll close it off now :)