Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for no overwrite option in convertLatLngs, #1092 #1246

Closed
wants to merge 2 commits into from

Conversation

snkashis
Copy link
Member

This provides for a parameter to allow people to bypass overwriting of existing arrays if needed.

References issue #1092

@tmcw
Copy link
Contributor

tmcw commented Feb 19, 2013

This should always be on, rather than being an option: #1426

@danzel
Copy link
Member

danzel commented Feb 19, 2013

agreed, will tidy this up now.

@mourner
Copy link
Member

mourner commented Feb 19, 2013

@tmcw Agreed too. Was going to fix this for 0.6 and check all other places for such things.

@snkashis
Copy link
Member Author

@mourner & @danzel, what else should I do here to get this ready? Just removed the option.

@mourner
Copy link
Member

mourner commented Feb 19, 2013

I'll check this out tomorrow, there may be some edge cases.

@danzel
Copy link
Member

danzel commented Feb 19, 2013

I've rebased a dev branch on your change and i'm working on it now, mainly writing some test cases to make sure everything is good.
I think the constructor and spliceLatLngs need some work too, but we'll see.

@danzel
Copy link
Member

danzel commented Feb 19, 2013

Looking good @snkashis.
Have pushed some tests up to a branch which includes your changes:
https://github.com/danzel/Leaflet/tree/convert_option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants