Leaflet's regular expressions with */ break lazy evaluation with multi line comments

[kristerkari]

Hi,

I would like to lazy evaluate Leaflet's javascript inside a mobile web app to boost parsing performance. source 1 source 2

Since I'm using a multi line comment to wrap my minified code, the javascript code that I have wrapped with a comment breaks because */ is used in some of Leaflet's regular expressions.

There are two places in the code where */ is used inside a regular expression, e.g. .replace(/(\S+)\s*/g, replaceFn)

Line 873 and Line 4382

Would it be possible to get rid of the closing multiline comment tags inside those regular expressions to fix the lazy evaluation problem?

[danzel]

I've read about this but never implemented it before, looks cool.

I don't think changing the regex is the right way to fix this.
Do you perhaps need to escape the javascript within the comment so that it doesn't have */ in it, or change stripOutCommentBlock to just remove the first and last 2 characters:
return code.substr(2, code.length - 4)

[kristerkari]

Do you perhaps need to escape the javascript within the comment so that it doesn't have */ in it

Yes it is possible, but then I need to do it manually every time. Would be nice to just drop the minified Leaflet inside a comment block each time there is a new realease

change stripOutCommentBlock to just remove the first and last 2 characters: return code.substr(2, code.length - 4)

That does not help since the problem is not there. It is the unescaped closing multi line comment tag (*/) in Leaflet's regular expressions that breaks the comment block causing a syntax error.

You can try it yourself by putting a minified version of Leaflet inside a multi line comment block.

[mourner]

If you have a way to change the regexs unobtrusively to fix the issue, please submit a pull request. I think this issue is too specific to keep it open here.