Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleMarker pixel radius issues #1297

Closed
jtreml opened this issue Jan 19, 2013 · 5 comments
Closed

CircleMarker pixel radius issues #1297

jtreml opened this issue Jan 19, 2013 · 5 comments
Assignees
Labels
Milestone

Comments

@jtreml
Copy link
Contributor

jtreml commented Jan 19, 2013

In Leaflet 0.5, the CircleMarker no longer seems to correctly draw with the set radius (in pixels) but draws a lot bigger than the set value.

Steps to reproduce:
See example at http://jtreml.github.com/leaflet.measure/example.html (click arrows icon on the left and then click on the map). The radius should be 2 pixels.

Environments tested:
MacBook Air with Safari
MacBook Pro Retina with Google Chrome

@snkashis
Copy link
Member

Take a look at my PR, placing radius in the options worked out. Perhaps there was some sort of chaining issue here?

@jtreml
Copy link
Contributor Author

jtreml commented Jan 21, 2013

Thanks, that solves the problem for now. Not sure about the chaining issue though. I have a dozen more examples that don't do any chaining and suffer from the same issue, like this one:

var marker = new L.CircleMarker(new L.LatLng(lat, lng), { color: 'black', opacity: 1, fillOpacity: 1, weight: 1, clickable: false });
marker.setRadius(1.5);
group.addLayer(marker);

@danzel
Copy link
Member

danzel commented Jan 21, 2013

Most likely setRadius is broken, I'll check tomorrow if mourner doesn't beat me to it.

@ghost ghost assigned danzel Jan 21, 2013
@mourner
Copy link
Member

mourner commented Feb 1, 2013

Dave, so did you have a chance to look at this?

danzel added a commit to danzel/Leaflet that referenced this issue Feb 3, 2013
@danzel
Copy link
Member

danzel commented Feb 3, 2013

Have now and fixed it :)
PR #1342

@danzel danzel closed this as completed in ded525f Feb 3, 2013
mourner added a commit that referenced this issue Feb 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants