Turn off animation of setView

[tmcw]

It doesn't seem like there's a way to tell Leaflet to animate or not to animate when you call setView. This is both an odd API choice and a problem for tests for that API, which would have to wait for the animation to finish.

[mourner]

In regards to API choice, you can pass true as a third argument to force center/zoom reset without any animation, and I thought that this covers most use cases.

The only case that it seemingly doesn't cover for tests is shifting of map pane when using panTo, but that can be covered through other means I guess.

[tmcw]

In regards to API choice, you can pass true as a third argument to force center/zoom reset without any animation, and I thought that this covers most use cases.

I'm reading setView in map.js - this is apparently replaced with PanAnimation.js. Is there any reason why it's not removed entirely or replaced more explicitly in code?

[mourner]

Yes, to work with a custom build where you don't include files with animation code.

If I come up with a way to make this mor elegant in the code, I'll refactor this. I agree that force replacement of methods like this isn't a very clean practice.

[mourner]

Merged into #1616.