_updateCanvasViewport() endless loop?

[lotrmj]

I tried rendering 10000 Canvas points (activated through L_PREFER_CANVAS) with L.CircleMarker and noticed that it's way slower than SVG. Than I noticed endless _updateCanvasViewport() loop, which is caused by 'this.on('moveend', this._updateCanvasViewport);'... Is it a bug?

[mourner]

@lotrmj can you check out if it's better on master version? I think it was recently fixed with #1713

[lotrmj]

Wow! What a coincidence the bug was found just few days before! I moved to Leaflet-Leaflet-21aa09b\dist\leaflet-src.js just today and the bug is present.

And my code to create a marker:

var poiShape;
poiShape = new L.CircleMarker([poiAttributes.x, poiAttributes.y], {
color: "#000000",
fillColor: this.poiFeatureLayerSettings.fillColor[poiAttributes.type],
fillOpacity: 1,
opacity: 1,
weight: 1
});
poiShape.setRadius(this.circleRadius);

And I tried using:

var poiShape;
poiShape = new L.Circle([poiAttributes.x, poiAttributes.y], {
color: "#000000",
fillColor: this.poiFeatureLayerSettings.fillColor[poiAttributes.type],
fillOpacity: 1,
opacity: 1,
weight: 1
});
poiShape.setRadius(this.circleRadius);

And the second one works just almost flawlessly!! I see you implemented mouseover pointer on canvas element. It works great in latest Mozilla Firefox, but cursor pointer is off to the right top in latest Google Chrome.

[mourner]

OK, I'll check this out. Thanks :)

[snkashis]

I'm not seeing this behavior in master...profiling isn't showing it to me either.

[lotrmj]

I dunno... I am using Leaflet-Leaflet-21aa09b\dist\leaflet-src.js and I still see this problem in Firefox 21.0 and Google Chrome 27.0.1453.94 m. And I cleared cache maybe ten times so far. Sadly, app is under development, so I can't post any link, nor code.

[snkashis]

Sorry, you are correct...@mourner hasn't updated the build yet, so you will have to build it yourself with jake. I just checked with the canvasloop debug page.

[mourner]

Oh, right :) will update a bit later. Thanks for checking thisnout Steve!

[snkashis]

no problem @mourner. @lotrmj can you elaborate on chrome pointer issue, perhaps with some screenshots? I'm in latest chrome as well.

[lotrmj]

Sorry, I don't have time these days to debug more, but I hope I will do more in three weeks, but I have these results now:

I tried rendering it on Opera 12.11. Mouseover() event seems to be ok, but the circle itself isn't closed, it looks like letter "C"

[snkashis]

Sounds like this deserves a separate issue maybe?