Layers control minimises itself too quickly in IE8

[kingrollo]

See the Leaflet example page here: http://leafletjs.com/examples/layers-control.html

Behaviour is as follows in IE8:

• Hover over the control, it expands
• Click on a layer name to change visibility, nothing happens and it minimises
• Click on a checkbox / radio to change visibility, it works but minimises immediately

This is different from the behaviour in Chrome/FF/etc:

• Hover over the control, it expands
• Click on a layer name, it changes visibility and stays expanded
• Click on a checkbox / radio, it changes visibility and stays expanded

I've just checked against Leaflet 0.5.1 and IE8 was working as expected.

[mourner]

Thanks, will take a look.

[mourner]

@danzel can you take a quick look at this one? My only guess is that it behaves like that because click now propagates to document (although the map ignores it), and it causes mouseout event on IE, but can't test atm.

I think this is the last bug to fix for 0.6.3 containing lots of bugfixes.

[jfirebaugh]

Looked at this briefly. I see L.DomEvent._fakeStop setting e._leaflet_stop on the click event, but when it gets to L.Map._onMouseClick, e._leaflet_stop is undefined -- either it got removed, or it's a different event object altogether.

[jfirebaugh]

it's a different event object altogether

This is indeed the case: http://stackoverflow.com/questions/7361869/attaching-properties-to-bubbled-event-object-in-javascript

[mourner]

Yeah, a tricky problem...

[danzel]

Will look at this today. We should probably be stopping propagation of clicks on inputs in the layers control. Why would you want a click you've handled by clicking on a input to propagate out?

[mourner]

Originally I added the fake event fix to make it possible to use popup content that relies on clicks propagating to document (e.g. some mobile frameworks like jQuery Mobile or code that uses event delegation like jQuery.on etc.).

In theory they may be cases where people would want to attach custom behavior to the layers control (e.g. in conjunction with the ability to pass html to it) from the outside through event delegation, but we may disregard that and just turn off the faking for the control (perhaps through a switch passed to disableClickPropagation).

[danzel]

We listen to the map click event, which gets fired because of the bug @jfirebaugh pointed out before.
I propose that we just don't listen to that event in old ie. See PR #1857

[jfirebaugh]

The IE bug is likely to cause problems with other controls that expect disableClickPropagation to actually work -- for example, a similar problem exists with clicking in a popup content. I think we need a more general fix or to remove the fake event stuff.

[danzel]

Ah bugger yeah you are right, hadn't thought about the popup one. :-(

[mourner]

Hmm, I think we should try setting the flag globally instead then, as it's only checked once on the map container click... And resetting it at the time of check too. That way it should work in IE too.

[mourner]

@danzel @jfirebaugh all right, how about this?