Pinch-Zoom fires click-event on Windows Phone 8 devices

[oliverheilig]

I made a simple leaflet application where you can select features from a GeoJson layer. I switched from 0.6.4 to the master branch, because pinch zoom for WinPoine8 didn't work well. Now the zoom itself seems to be correct, but after a zoom the feature under one finger is selected. This doesn't occur in other browsers and in the 0.6.4 version. You can reproduce the behavior here.

http://oliverheilig.github.io/LindasWorldQuiz/FindCountry.html

[mourner]

@danzel can you take a look?

[danzel]

on it.

[danzel]

http://www.w3.org/Submission/pointer-events/#compatibility-mapping-with-mouse-events
Looks like dragging avoids it by L.DomEvent._skipped(e); in stopPropogation (as a click event still occurs on the body if you do a drag)
But this doesn't happen when you pinch zoom for some reason... Will investigate more tomorrow.

Really weird that click events occur when you move your finger though.

[danzel]

https://dvcs.w3.org/hg/pointerevents/raw-file/tip/pointerEvents.html#compatibility-mapping-with-mouse-events
Might be newer by the looks.

http://lists.w3.org/Archives/Public/public-pointer-events/2012OctDec/0075.html
https://www.w3.org/Bugs/Public/show_bug.cgi?id=20240

Just gotta work out why click fires even when I drag...

[danzel]

I've bashed my head against this for 2 more hours, this is still confusing me.

If you comment out:
https://github.com/Leaflet/Leaflet/blob/master/src/dom/DomEvent.Pointer.js#L40

Then clicks stop happening, BUT the zoom animation for markers is all messed up like in 0.6.4
if you then hack Draggable._onMove to just return (with or without preventDefault), we get a correct zoom animation but go back to click events occurring again!
https://github.com/Leaflet/Leaflet/blob/master/src/dom/Draggable.js#L76

I'm thinking this may be an IE on WP8 bug, I'll try reproduce outside of leaflet

[danzel]

Bug reproduces in IE 10 touch. Awaiting our IE 11 touch device to be in the office tomorrow, looks like we might need to add a hack :(
So weird that it doesn't happen for drags, it does on my test page.

[danzel]

Okay, just reused the dragging click prevention hack, PR #2117
Not sure if this is the best way to fix it, but it fixes it in my testing.

@mourner - thoughts?
The issue is that on IE10 touch, when releasing your fingers after a touch zoom click events are generated, so we need to avoid them.

@oliverheilig I haven't tested with clickable vector layers, not sure if this will fix the issue for that case, so please test.