New disableTextSelection causes a slow drag start

[danzel]

New on front page of leaflet:

New on our internal app, this takes a noticeable amount of time:

(layout below it is 5ms on a input text box)
Stack trace comes back to https://github.com/Leaflet/Leaflet/blob/master/src/dom/DomUtil.js#L236

old on our internal app

There is no recalculate style immediately after the mouse down, drag is nicer.

The one that occurs later in the drag for both is hiding the already hidden layers control, I'll take a look at that.
https://github.com/Leaflet/Leaflet/blob/master/src/control/Control.Layers.js#L242

@jfirebaugh You implemented the text select change in #1782, any ideas? :)

[mourner]

Related issue (where resetting the disable methods is reported to fix drag chopinness in the comments) #2009

[mourner]

OK it seems that we've figured this out with @jfirebaugh. In short,

jfire: vladimir: when in doubt copy what mbostock did :)

d3/d3@91506b3

[mourner]

Related D3 issue: d3/d3/issues/1599

[danzel]

Weird, yeah it is only the first frame of the drag, the rest is fine.
Thanks for the links :)

[mourner]

You're welcome! John will pull this in.

[danzel]

@mourner I take it you are going to do the change?
I'll look at the layers control one

[mourner]

@danzel nope, @jfirebaugh will. Yeah, please look at the layers control one.

[danzel]

Awesome

[mourner]

@jfirebaugh thanks mate!

[danzel]

Awesome, this improves the situation quite a bit.

Updating leaflet removed the layers control issue, just one big purple blob left:
https://github.com/Leaflet/Leaflet/blob/master/src/dom/Draggable.js#L95
Will make a new issue.